- 10 Jul, 2020 40 commits
-
-
Adam Hegyi authored
This MR fixes a bug where the issuable filter params were ignored.
-
Martin Wortschack authored
Add broken tag state to tags list items See merge request gitlab-org/gitlab!36442
-
Nicolò Maria Mezzopera authored
- update component - adjust tests
-
Ash McKenzie authored
Move secure eslint analyzer to core See merge request gitlab-org/gitlab!36392
-
Kushal Pandya authored
Add FilteredSearchBar for search and sort See merge request gitlab-org/gitlab!36413
-
Dylan Griffith authored
Exclude integrations (services) from Project Import/Export See merge request gitlab-org/gitlab!35249
-
Natalia Tepluhina authored
Geo - GraphQL Remove Edges Closes #227385 See merge request gitlab-org/gitlab!36491
-
Natalia Tepluhina authored
Step 3 - Setup testURL in jest jsdom See merge request gitlab-org/gitlab!36407
-
Paul Slaughter authored
- Make test_constants CommonJS style - Update old refs to localhost with TEST_HOST
-
Heinrich Lee Yu authored
Attempt to make signed_commits_spec.rb less flaky Closes #216530 See merge request gitlab-org/gitlab!36534
-
Heinrich Lee Yu authored
Add author link to the Jira issue entity See merge request gitlab-org/gitlab!36310
-
Kushal Pandya authored
Replace fa-comment / fa-comments icons with GitLab SVG See merge request gitlab-org/gitlab!36206
-
Heinrich Lee Yu authored
Fix pagination parameters for Jira issue list See merge request gitlab-org/gitlab!36427
-
Kushal Pandya authored
Merge branch '212811-adding-new-task-always-shows-error-something-went-wrong-while-fetching-latest-comments' into 'master' Fix polling for notes See merge request gitlab-org/gitlab!36043
-
Mark Florian authored
Previously, the `dispatch` store function wasn't passed to the `pollSuccessCallback` helper, which was causing an error message to appear when loading an MR. This ensures that is passed correctly along. Addresses https://gitlab.com/gitlab-org/gitlab/-/issues/212811
-
Stan Hu authored
The examples in this spec often attempt to click a popover before the JavaScript handler is initialized. Since we don't have a good way to detect when initialization has completed, we wait for all requests to finish in an attempt to give the page more time to load before attempting to click. This won't guarantee that it solves the problem--we'd have to have some indicator like a newly-added class--but hopefully this will work around the problem for now. Closes https://gitlab.com/gitlab-org/gitlab/-/issues/216530
-
Jan Provaznik authored
Calculate and store vulnerability statistics on database See merge request gitlab-org/gitlab!35052
-
Ash McKenzie authored
Remove reference to sast:container See merge request gitlab-org/gitlab!32061
-
Adam Cohen authored
-
Evan Read authored
Document how to enable strong consistency See merge request gitlab-org/gitlab!36426
-
Bob Van Landuyt authored
Fix commit message for Crowdin See merge request gitlab-org/gitlab!36288
-
Ezekiel Kigbo authored
Revert "Merge branch '213699-remove-search-results-autocomplete' into 'master'" Closes #223841 See merge request gitlab-org/gitlab!35983
-
Patrick Steinhardt authored
With strong consistency nearing beta stage, we need to document what it does and how to enable it to give it a try. So let's do so.
-
Marcel Amirault authored
Docs: Added latest templates See merge request gitlab-org/gitlab!36503
-
Dylan Griffith authored
Merge branch '221211-improve-performance-of-group-search-api-advanced-merge_requests-scope' into 'master' Resolve "Improve performance of Group Search API (advanced): merge_requests scope" Closes #221211 See merge request gitlab-org/gitlab!36072
-
Dylan Griffith authored
Instrument PyPI and Composer events via Snowplow Closes #214905 See merge request gitlab-org/gitlab!36514
-
Tim Rizzi authored
-
Dylan Griffith authored
Resolve remaining N+1 in Search API (Advanced) projects scope Closes #218703 See merge request gitlab-org/gitlab!35833
-
Dmitry Gruzd authored
-
Shinya Maeda authored
Load correct iteration on iteration report See merge request gitlab-org/gitlab!34842
-
Simon Knox authored
Also unquarantine test, as it will load correct item now Remove sign_in as not needed to view
-
Justin Ho authored
Add `wrapper = null` to properly clean up after each spec
-
Mike Greiling authored
Add controls to enable viewing Jira issues within GitLab See merge request gitlab-org/gitlab!35417
-
Justin Ho Tuan Duong authored
Currently only a skeleton of the changes required.
-
Evan Read authored
Change single quotes around private token to double quotes See merge request gitlab-org/gitlab!36506
-
Evan Read authored
Change single quotes to double quotes See merge request gitlab-org/gitlab!36507
-
Justin Ho authored
- Use Vue component to avoid needing to refresh the page - Allow search (free text) and sort - Only show for Jira issues
-
Micael Bergeron authored
-
James Fargher authored
Fix IndexStatus find_or_create race condition See merge request gitlab-org/gitlab!36266
-
Dylan Griffith authored
**TL;DR** Fix a race condition where `IndexStatus` is not created and does not raise error. Need to use `!` and get rid of problematic unique model validation. Looking at the code I notice a logical problem with using `find_or_create_by` alongside a unique model validation. The problem is a race condition which comes from `find_or_create` first checking to see if the record exists. If it does not it tries creating which then invokes the validation which checks again to see if the record exists which finally returns a validation error. But see here we are not using `!` version of `find_or_create` and so this validation error is silently ignored. Since we already have a [`safe_find_or_create_by!`]( https://gitlab.com/gitlab-org/gitlab/-/blob/2b01f1f3420d9177e27418df063aad2e1bda1216/app/models/application_record.rb#L37 ) which is designed for handling this race condition using unique indexes and rescue and seeing that this model already has the [unique index]( https://gitlab.com/gitlab-org/gitlab/-/blob/2b01f1f3420d9177e27418df063aad2e1bda1216/db/structure.sql#L19266 ) we should just get rid of the model validation since it just complicates the error handling. Since this is a pretty weird race condition it seems tricky/contrived to try to create a proper unit test for this case.
-