1. 28 Dec, 2020 20 commits
  2. 26 Dec, 2020 2 commits
    • Stan Hu's avatar
      Fix flaky spec in QuickActions::InterpretService#execute · c4e9e784
      Stan Hu authored
      The spec was attempting to test whether `/assign @userA @userB` would
      only assign an issue or merge request to `userA`. However, this would
      fail occasionally because the reference extractor does not guarantee
      ordering with extracted Markdown references since a database lookup is
      performed (e.g. `User.where`) without an ORDER BY.
      
      We adapt the test to check that only one of the two possible users is
      assigned since the behavior is ambiguous when multiple assignees is not
      supported, and it would take some work with some performance
      implications to ensure the first mentioned user were assigned.
      
      Closes https://gitlab.com/gitlab-org/gitlab/-/issues/27989
      c4e9e784
    • Stan Hu's avatar
      Merge branch '292679-add-users-request-specs' into 'master' · d6805f4f
      Stan Hu authored
      Replace user controller spec with its request spec
      
      See merge request gitlab-org/gitlab!50435
      d6805f4f
  3. 25 Dec, 2020 18 commits