An error occurred fetching the project authors.
  1. 17 May, 2018 1 commit
  2. 09 May, 2018 1 commit
  3. 19 Dec, 2017 2 commits
    • Robert Speicher's avatar
      Only include the user's ID in the time_spent command's update hash · 3e4b45fc
      Robert Speicher authored
      Previously, this would include the entire User record in the update
      hash, which was rendered in the response using `to_json`, erroneously
      exposing every attribute of that record, including their (now removed)
      private token.
      
      Now we only include the user ID, and perform the lookup on-demand.
      3e4b45fc
    • Robert Speicher's avatar
      Only include the user's ID in the time_spent command's update hash · 8a7bd7ec
      Robert Speicher authored
      Previously, this would include the entire User record in the update
      hash, which was rendered in the response using `to_json`, erroneously
      exposing every attribute of that record, including their (now removed)
      private token.
      
      Now we only include the user ID, and perform the lookup on-demand.
      8a7bd7ec
  4. 30 Nov, 2017 1 commit
    • Lin Jen-Shin's avatar
      Merge branch 'no-ivar-in-modules' into tmp · 91756788
      Lin Jen-Shin authored
      * no-ivar-in-modules:
        Cache allowed_ids
        Fix a few layout error
        Make it clear that this is an acceptable use
        Reword Instance variables in views
        Move ModuleWithInstanceVariables to Gitlab namespace
        Explain how to disable it in the doc
        Just define allowed_ids and override it with empty value
        Updates based on feedback
        Remove codes from bad merge
        Allow initialize method and single ivar
        Use StrongMemoize and enable/disable cops properly
        WIP
        Fix grammar: judge -> judgement
        Allow simple ivar ||= form. Update accordingly
        Add cop to make sure we don't use ivar in a module
      91756788
  5. 22 Nov, 2017 2 commits
  6. 17 Nov, 2017 1 commit
  7. 13 Oct, 2017 1 commit
  8. 12 Oct, 2017 1 commit
  9. 18 Sep, 2017 2 commits
  10. 06 Jul, 2017 2 commits
    • Yorick Peterse's avatar
      Added Cop to blacklist the use of `dependent:` · 8fbbf41e
      Yorick Peterse authored
      This is allowed for existing instances so we don't end up 76 offenses
      right away, but for new code one should _only_ use this if they _have_
      to remove non database data. Even then it's usually better to do this in
      a service class as this gives you more control over how to remove the
      data (e.g. in bulk).
      8fbbf41e
    • Yorick Peterse's avatar
      Added Cop to blacklist the use of `dependent:` · dddf1378
      Yorick Peterse authored
      This is allowed for existing instances so we don't end up 76 offenses
      right away, but for new code one should _only_ use this if they _have_
      to remove non database data. Even then it's usually better to do this in
      a service class as this gives you more control over how to remove the
      data (e.g. in bulk).
      dddf1378
  11. 07 Feb, 2017 1 commit
    • Ruben Davila's avatar
      Use normal associations instead of polymorphic. · bdc93224
      Ruben Davila authored
      We can't properly use foreign keys on columns that are configured for
      polymorphic associations which has disadvantages related to data
      integrity and storage. Given we only use time tracking for Issues and
      Merge Requests we're moving to the usage of regular associations.
      bdc93224
  12. 19 Jan, 2017 1 commit
    • Ruben Davila's avatar
      Add some API endpoints for time tracking. · 847f621d
      Ruben Davila authored
      New endpoints are:
      
      POST :project_id/(issues|merge_requests)/(:issue_id|:merge_request_id)/time_estimate"
      
      POST :project_id/(issues|merge_requests)/(:issue_id|:merge_request_id)/reset_time_estimate"
      
      POST :project_id/(issues|merge_requests)/(:issue_id|:merge_request_id)/add_spent_time"
      
      POST :project_id/(issues|merge_requests)/(:issue_id|:merge_request_id)/reset_spent_time"
      
      GET  :project_id/(issues|merge_requests)/(:issue_id|:merge_request_id)/time_stats"
      847f621d
  13. 18 Jan, 2017 1 commit
    • Ruben Davila's avatar
      Add some API endpoints for time tracking. · 0f3c9355
      Ruben Davila authored
      New endpoints are:
      
      POST :project_id/(issues|merge_requests)/(:issue_id|:merge_request_id)/time_estimate"
      
      POST :project_id/(issues|merge_requests)/(:issue_id|:merge_request_id)/reset_time_estimate"
      
      POST :project_id/(issues|merge_requests)/(:issue_id|:merge_request_id)/add_spent_time"
      
      POST :project_id/(issues|merge_requests)/(:issue_id|:merge_request_id)/reset_spent_time"
      
      GET  :project_id/(issues|merge_requests)/(:issue_id|:merge_request_id)/time_stats"
      0f3c9355
  14. 15 Jan, 2017 1 commit
  15. 19 Dec, 2016 2 commits
  16. 17 Nov, 2016 1 commit
  17. 16 Nov, 2016 3 commits
  18. 15 Nov, 2016 2 commits
  19. 14 Nov, 2016 1 commit
  20. 12 Nov, 2016 1 commit
  21. 11 Nov, 2016 1 commit
  22. 10 Nov, 2016 2 commits