- 17 Apr, 2019 36 commits
-
-
GitLab Bot authored
-
Nick Thomas authored
Rewrite "Review turnaround time" section in light of Global Optimization value See merge request gitlab-org/gitlab-ce!27411
-
Sanad Liaquat authored
Resolve "Add QA tests for the performance bar" Closes #60356 See merge request gitlab-org/gitlab-ce!27305
-
GitLab Bot authored
-
Sean McGivern authored
Fix extra emails for custom notifications Closes #56861 See merge request gitlab-org/gitlab-ce!25607
-
Patrick Derichs authored
Using custom_action and recipient filtering Add more generic filtering to user_ids_notifiable_on Add changelog entry Remove commented class Method is no longer needed Overloading no longer required Filter by action just in case of custom notification level Add participant check Fix unexpected extra notification mails Using custom_action and recipient filtering Add more generic filtering to user_ids_notifiable_on Add changelog entry Remove commented class Method is no longer needed Overloading no longer required Filter by action just in case of custom notification level Fix comment Add repond_to? checks Reverted custom_action filtering Enhanced output of should_email helper Changed :watch to :participating for custom notifiable users Change spec variable name Enhanced participating check These conditions are no longer needed Fix custom notification handling for participating type Participating level should include maintainers Fixed add_guest notification Fix successful pipeline notification Refactoring: Use maintainer? method on team instead Add spec for new_issue: true for a custom group setting which should have lower prio than an available project setting Clean up specs
-
Achilleas Pipinellis authored
Add note about MR Pipeline Runner version Closes gitlab-ee#11122 See merge request gitlab-org/gitlab-ce!27330
-
Achilleas Pipinellis authored
Docs: Fix typo on DB migration See merge request gitlab-org/gitlab-ce!27435
-
Achilleas Pipinellis authored
Update external prometheus config See merge request gitlab-org/gitlab-ce!27439
-
Filipa Lacerda authored
Removes EE diffs for dropdown_value_collapsed.vue Closes gitlab-ee#10083 See merge request gitlab-org/gitlab-ce!27367
-
Filipa Lacerda authored
Ports 10083-dropdown-ce-ee-difference See merge request gitlab-org/gitlab-ee!10992
-
GitLab Bot authored
-
Filipa Lacerda authored
Backport of "Resolves EE differences for project_new.js" See merge request gitlab-org/gitlab-ce!27285
-
Donald Cook authored
-
Achilleas Pipinellis authored
Fix typo See merge request gitlab-org/gitlab-ce!27443
-
Ken McKnight authored
-
Filipa Lacerda authored
Fix stylelint warnings in related_items_list.scss See merge request gitlab-org/gitlab-ce!27432
-
Filipa Lacerda authored
Fix stylelint warnings in related_items_list.scss See merge request gitlab-org/gitlab-ee!10897
-
Filipa Lacerda authored
Fix stylelint rules in boards.scss Closes #59895 See merge request gitlab-org/gitlab-ce!27313
-
GitLab Bot authored
-
Phil Hughes authored
Removes ifEE example for JS code. See merge request gitlab-org/gitlab-ce!27408
-
GitLab Bot authored
-
Phil Hughes authored
Add help texts to K8 form fields Closes #59275 See merge request gitlab-org/gitlab-ce!27274
-
Enrique Alcántara authored
-
Phil Hughes authored
EE port: Add help texts to K8 form fields See merge request gitlab-org/gitlab-ee!10792
-
Enrique Alcántara authored
-
GitLab Bot authored
-
Lin Jen-Shin authored
Fix logic in Api::Internal test See merge request gitlab-org/gitlab-ce!27193
-
Steve Azzopardi authored
-
GitLab Bot authored
-
Grzegorz Bizon authored
Allow extra args for helm in Auto-DevOps See merge request gitlab-org/gitlab-ce!26838
-
GitLab Bot authored
-
Michael Kozono authored
[CE backport] Fix no assignee text in sidebar_spec See merge request gitlab-org/gitlab-ce!27444
-
Michael Kozono authored
Fix no assignee text in sidebar_spec Closes #11192 See merge request gitlab-org/gitlab-ee!11099
-
Michael Kozono authored
Use max of approvals_before_merge between project and MR at runtime Closes #10909 and #10055 See merge request gitlab-org/gitlab-ee!10766
-
Mark Chao authored
Previously, MR#approvals_before_merge is nil when it is <= project (from `clamp_approvals_before_merge`). This changed in f480d145, which would always persist a min value. This caused regression that updating MR would fail if project's value is increased later on. The relationship between value being nil and validation can be easily overlooked. Removing validation and taking the max of the two makes logic clearer.
-
- 16 Apr, 2019 4 commits
-
-
Luke Bennett authored
-
Luke Bennett authored
-
Luke Duncalfe authored
The intention of this test is to ensure that the service class MergeRequests::PushOptionsHandlerService does not run when the :mr_push_options feature flag is disabled. This test was passing, however was not testing what it was supposed to be! For one, setting Feature.disable(:feature) in the test does not disable the feature, as rspec config in spec_helper stubs Feature to make all features enabled: https://gitlab.com/gitlab-org/gitlab-ce/commit/3ee48e422defaedd69946c607bd8d3672e510375 So the feature was still enabled in the test. But this test wasn't failing because unfortunately I had put: ``` expect(MergeRequests::PushOptionsHandlerService).to receive(:new) ``` instead of not_to! This meant that the `.new` method was being stubbed, so the service class did not create a MergeRequest, which satisfied the second expectation. ``` expect(MergeRequests::PushOptionsHandlerService).to receive(:new) ```
-
Cindy Pallares authored
Updated to include missing metrics: * GitLab Workhorse * Nginx * Sidekiq
-