1. 22 Jul, 2016 4 commits
    • Rémy Coutable's avatar
      Merge branch 'artifacts-from-ref-and-build-name-api' into 'master' · 50124864
      Rémy Coutable authored
      Simpler two queries than one JOIN with subquery
      
      This is a follow up from !5347
      
      Originally it was:
      
      ``` ruby
      pipeline = pipelines.latest_successful_for(ref)
      builds.where(pipeline: pipeline).latest.with_artifacts
      ```
      
      However MySQL would complain that we can't use `IN` against a subquery which has `LIMIT`. Using `INNER JOIN` would be a workaround, however, doing that is too complicated in current version of Rails.
      
      So let's just use two queries in this case.
      
      Closes #14419
      
      See merge request !5388
      50124864
    • Achilleas Pipinellis's avatar
      Merge branch 'namespace' into 'master' · cbe787c5
      Achilleas Pipinellis authored
      Explain CI_PROJECT_NAMESPACE better
      
      ## What does this MR do?
      
      Explain CI_PROJECT_NAMESPACE better by adding "The project namespace (username or groupname) that is currently being built".
      
      ## Are there points in the code the reviewer needs to double check?
      
      Are `username` and `groupname` known words? We use it [here](http://docs.gitlab.com/ee/api/namespaces.html).
      
      ## Why was this MR needed?
      
      Because `namespace` isn't a well known term.
      
      ## What are the relevant issue numbers?
      
      ## Screenshots (if relevant)
      
      
      See merge request !5407
      cbe787c5
    • Stan Hu's avatar
      Merge branch '20079-new-wiki-page-500-spec' into 'master' · 6c9d1a08
      Stan Hu authored
      Add a spec for #20079
      
      - This MR adds a spec for the fix for #20079 that was implemented in !5400.
      - The spec is going in separately, just so the fix could go in as soon as possible.
      
      See merge request !5414
      6c9d1a08
    • Timothy Andrew's avatar
      Add a spec for #20079. · c3cbee10
      Timothy Andrew authored
      The issue was fixed in 2ba5e625. The spec is going in separately just
      so the fix could go in as soon as possible.
      c3cbee10
  2. 21 Jul, 2016 36 commits