1. 15 Sep, 2016 11 commits
  2. 14 Sep, 2016 24 commits
  3. 13 Sep, 2016 5 commits
    • Robert Speicher's avatar
      Merge branch 'pushes-since-gc-redis' into 'master' · 4f6ad25b
      Robert Speicher authored
      Move pushes_since_gc to Redis
      
      ## What does this MR do?
      
      This moves tracking of the pushes since the last Git GC to Redis to reduce DB load.
      
      ## Are there points in the code the reviewer needs to double check?
      
      Styling mostly.
      
      ## Why was this MR needed?
      
      Updating this column can lead to a lot of writes which in turn puts a lot of load on table vacuuming. For example, in the last hour alone we had 5067 UPDATEs for this column (per InfluxDB):
      
      ```
      > select count(increment_pushes_since_gc_call_count) from sidekiq_transactions where time > now() - 1h;
      name: sidekiq_transactions
      --------------------------
      time                    count
      1473780996567714622     5067
      ```
      
      ## What are the relevant issue numbers?
      
      https://gitlab.com/gitlab-org/gitlab-ce/issues/22125
      
      See merge request !6326
      4f6ad25b
    • Stan Hu's avatar
      Merge branch 'workhorse-secret-trailing-newline' into 'master' · 746bf485
      Stan Hu authored
      Allow trailing newline in secret base64 data
      
      Fixes https://gitlab.com/gitlab-org/omnibus-gitlab/issues/1575
      
      See merge request !6327
      746bf485
    • Yorick Peterse's avatar
      Move pushes_since_gc to Redis · 4e87c023
      Yorick Peterse authored
      This moves tracking of the pushes since the last Git GC from PostgreSQL
      to Redis. This reduces the number of writes on the "projects" table.
      This in turn reduces the vacuuming overhead.
      
      The lease used for incrementing the counter has been removed. This lease
      was mostly put in place to prevent high database load but this isn't
      needed anymore due to the counter now being stored in Redis.
      
      Fixes gitlab-org/gitlab-ce#22125
      4e87c023
    • Robert Speicher's avatar
      Merge branch 'rc-use-haml_lint' into 'master' · acc7f7c6
      Robert Speicher authored
      Use `haml_lint` for views linting
      
      ## What does this MR do?
      
      Add HAML-linting to the GitLab codebase.
      
      ## What are the relevant issue numbers?
      
      Closes #19984.
      
      See merge request !6307
      acc7f7c6
    • Ahmad Sherif's avatar
      Fix Gitlab::Popen.popen thread-safety issue · c90174af
      Ahmad Sherif authored
      Fixes #21842
      c90174af