1. 16 Feb, 2021 7 commits
    • Dylan Griffith's avatar
      Fix flaky epics_finder_spec race condition · 55c2a9bd
      Dylan Griffith authored
      As per https://gitlab.com/gitlab-org/gitlab/-/issues/321511 we've seen
      one of these tests fail. It seems likely the problem is caused by the
      use of `X.days.ago` throughout and then filtering with date ranges. The
      likely explanation is that when the test is running just before midnight
      then `2.days.ago` actually ends up being "3 days ago" from a date
      perspective by the time the assertion is made about it.
      
      Even though it's not easy to replicate this exact failure mode and this
      flakiness has never happened for this spec before (to my knowledge) in 3
      years it still is not a good way to write these kinds of tests as this
      is theoretically a problem.
      
      Instead of making all the times relative to "now" (which changes) I've
      just made everything relative to some arbitrary fixed time. This works
      fine, without any need for freezing time, as none of the methods being
      tested actually refer to the current time.
      
      The test is still quite difficult to read due to many different dates
      and times and the fact that the examples are separated from the test
      setup but I don't think this change makes it less clear.
      55c2a9bd
    • Luke Duncalfe's avatar
      Merge branch 'psimyn-master-patch-99412' into 'master' · 2dba2182
      Luke Duncalfe authored
      Fix flaky calendar spec by clicking the same cell again
      
      See merge request gitlab-org/gitlab!54281
      2dba2182
    • Simon Knox's avatar
      Fix flaky calendar spec by clicking the same cell again · dada5197
      Simon Knox authored
      We recently added more tabs which pushed the tabs to the left
      and meant the Overview tab is obscured by a tooltip.
      So instead we now click, then wait, then click the same cell again
      Unsure if it's actually supposed to behave like this, but it does
      dada5197
    • Heinrich Lee Yu's avatar
      Merge branch 'remove-ci-custom-tags-ff-300155' into 'master' · dd1a6d26
      Heinrich Lee Yu authored
      Remove ci_custom_yaml_tags feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]
      
      See merge request gitlab-org/gitlab!54198
      dd1a6d26
    • Gabriel Mazetto's avatar
      Merge branch 'fzimmer-master-patch-38476' into 'master' · 208ddefb
      Gabriel Mazetto authored
      Added maintenance mode to planned failover
      
      See merge request gitlab-org/gitlab!53149
      208ddefb
    • Heinrich Lee Yu's avatar
      Merge branch '299234-api-fuzzing-config-mutation' into 'master' · 33311ac7
      Heinrich Lee Yu authored
      Add GraphQL mutation for configuring API fuzzing scans
      
      See merge request gitlab-org/gitlab!53883
      33311ac7
    • Avielle Wolfe's avatar
      Add API fuzzing create config mutation · ca0b7645
      Avielle Wolfe authored
      The mutation has all of its fields and arguments, but does not yet
      contain any functionality.
      ca0b7645
  2. 15 Feb, 2021 33 commits