1. 03 Jul, 2019 1 commit
    • Stan Hu's avatar
      Fix order-dependent Gitaly specs failing · 645c7f96
      Stan Hu authored
      If `spec/tasks/gitlab/cleanup_rake_spec.rb` preceded any of the Gitaly
      request specs, it would import the `cleanup.rake` and the global
      function `limit`. For some reason, the Protobuf implementation would use
      the global function instead of the getter method. For example:
      
      ```
      def limit
        puts "hi"
      end
      
      req = Gitaly::WikiGetAllPagesRequest.new
      req.send(:limit)
      hi
      => nil
      ```
      
      To fix this problem, access the field value using the [] operator
      instead.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64006
      645c7f96
  2. 02 Jul, 2019 39 commits