- 05 Feb, 2019 40 commits
-
-
Paul Slaughter authored
Neded for client side validation and needed to know if a MR rule should be editable or not.
-
Paul Slaughter authored
-
Mark Chao authored
Use existing project PUT to update
-
Mark Chao authored
fallback_approvals_required should be checked in conjunction with code owner rules (if any)
-
Mark Chao authored
Specs are based from existing approvable spec.
-
Mark Chao authored
-
Mark Chao authored
Update spec
-
Mark Chao authored
-
Mark Chao authored
-
Mark Chao authored
-
Mark Chao authored
-
Mark Chao authored
-
Mark Chao authored
No longer need to consider overall_approvals_required
-
Mark Chao authored
-
Mark Chao authored
Fix spec so fallback path is tested
-
Mark Chao authored
-
Mark Chao authored
-
Mark Chao authored
It is helpful to not duplicate these paths in the FE.
-
Mark Chao authored
For the `approvals_settings` response. It was needed because we automatically populate the MR `rules` from the project if necessary, but there was no way for the edit UI to know if these were project rules or MR rules.
-
Mark Chao authored
-
Mark Chao authored
Now endpoints are under approval_settings scope.
-
Mark Chao authored
This excludes code owner rule
-
Mark Chao authored
Now endpoints are under approval_settings scope. Add PUT /projects/:id/approval_settings for updating overall approvals_required.
-
Mark Chao authored
Combine checking query
-
Mark Chao authored
Allow assigning project rule for MR rule When no MR approval rule, we don't validate as project rule will be used.
-
Mark Chao authored
This is to recompute the new overall_approvers In this method, the following calls would cause a change in the database which needs resetting the cache: - super (which updates MR) - sync_approval_rules (which updates rule record's approvals_required) - cleanup_approvers (which removes any approver not mentioned in params) resetting cache must be done after those three calls, so moving some calls earlier is required. However this would not affect outcome.
-
Mark Chao authored
Accepts nested attribute for rules
-
Mark Chao authored
Only allow updating if user can update project/MR
-
Mark Chao authored
Handles both project and MR rules
-
Mark Chao authored
Ensure MR rule approvals_required > PR rule's
-
GitLab Bot authored
-
Yorick Peterse authored
Author is Developer in sec. release MR template See merge request gitlab-org/gitlab-ce!24934
-
Filipa Lacerda authored
Added fuzzy file finder to merge requests Closes #53304 See merge request gitlab-org/gitlab-ce!24434
-
GitLab Bot authored
-
Marcia Ramos authored
Instructions on how to use Pages templates Closes #56991 See merge request gitlab-org/gitlab-ce!24796
-
Jason Lenny authored
-
GitLab Release Tools Bot authored
[ci skip]
-
GitLab Release Tools Bot authored
[ci skip]
-
Sean McGivern authored
Adds helper for `find_or_create_by` in transaction See merge request gitlab-org/gitlab-ce!24913
-
Phil Hughes authored
Improves title in FF empty state Closes #9282 See merge request gitlab-org/gitlab-ee!9425
-