- 18 Jul, 2019 40 commits
-
-
Patrick Bajao authored
When `disable_overriding_approvers_per_merge_request` is set to `true`, we must not allow anyone to override the approvers per merge request. To ensure this, we shouldn't pass `approval_rules_attributes` param when creating or updating a merge request whenever it is not allowed to override the approvers per merge request. Fix is to add a check to `ApprovalRules::ParamsFilteringService` to delete the `approval_rules_attributes` from params when it's not allowed.
-
Stan Hu authored
Merge branch 'extract-vulnerabilities-actions-from-group-security-vulnerabilities-controller' into 'master' Extract vulnerabilities actions from group security vulnerabilities controller See merge request gitlab-org/gitlab-ee!14476
-
GitLab Bot authored
-
Lin Jen-Shin authored
Adds chaos endpoints to Sidekiq Closes #64663 See merge request gitlab-org/gitlab-ce!30814
-
Avielle Wolfe authored
This allows us to more easily stub paginates_per in specs, as well as clarifies a mystery number. (Not that it was too difficult to understand before, but it's nicer now.)
-
Avielle Wolfe authored
It's unnecessarily heavy when we can modify how many occurrences we paginate on.
-
Avielle Wolfe authored
(where possible)
-
Avielle Wolfe authored
There was some unnecessary duplication.
-
Avielle Wolfe authored
Since groups can contain multiple projects, we need to check that all related vulnerabilities all included in the response.
-
Avielle Wolfe authored
This cleans up the code by allowing us to set subject once for each set of action specs and redefine the params for the request under test only when necessary.
-
Avielle Wolfe authored
-
Avielle Wolfe authored
Since there is no equivalent in CE, it doesn't need to be under the EE namespace.
-
Avielle Wolfe authored
They will work with Projects or Groups now.
-
Avielle Wolfe authored
They were testing some functionality that is the responsibility of the VulnerabilitiesFinder, not the controllers.
-
Avielle Wolfe authored
Access to these endpoints is controlled by the Group::Security::ApplicationController, so these specs shouldn't be shared.
-
Avielle Wolfe authored
Next step: smooth this puppy out
-
Marin Jankovski authored
Add issue link to disabled JUnit reports See merge request gitlab-org/gitlab-ce!30912
-
Winnie Hellmann authored
-
GitLab Bot authored
-
Dan Davison authored
Fix QA documentation to refer to perform method See merge request gitlab-org/gitlab-ce!30872
-
Dan Davison authored
The documentation referred to the .act method This MR changes this to refer to the preferred .perform method
-
GitLab Bot authored
-
Bob Van Landuyt authored
CE port for milestones should not be set on epics issue promotion See merge request gitlab-org/gitlab-ce!30633
-
Eugenia Grieff authored
-
Bob Van Landuyt authored
Resolve "Milestones should not be set on epics (issue promotion)" Closes #10270 See merge request gitlab-org/gitlab-ee!14532
-
Eugenia Grieff authored
-
GitLab Bot authored
-
Sean McGivern authored
Fix bug in dashboard display of closed milestones Closes #59381 See merge request gitlab-org/gitlab-ce!30820
-
GitLab Bot authored
-
Stan Hu authored
Enable RuboCop syntax linting in haml-lint Closes #64753 See merge request gitlab-org/gitlab-ce!30903
-
Andrew Newdigate authored
This allows the chaos endpoints to be invoked in Sidekiq so that this environment can be tested for resilience.
-
GitLab Bot authored
-
Stan Hu authored
Fix broken handling for outdated test repos See merge request gitlab-org/gitlab-ce!30893
-
Bob Van Landuyt authored
Security gates within MRs - Sync security report_approvers to pipeline security reports See merge request gitlab-org/gitlab-ee!13109
-
Lucas Charles authored
Adds SyncSecurityReportsToReportApprovalRulesWorker responsible for conditionally zero'ing out `approvals_required` when a report contains no high-severity or critical-severity vulnerabilities
-
GitLab Bot authored
-
Stan Hu authored
Update usage ping cron behavior See merge request gitlab-org/gitlab-ce!30842
-
GitLab Bot authored
-
Mayra Cabrera authored
Improves add_timestamps_with_timezone helper See merge request gitlab-org/gitlab-ce!30720
-
Alex Kalderimis authored
This improves the `add_timestamps_with_timezone` helper by allowing the column names to be configured. This has the advantage that unnecessary columns can be avoided, saving space. A helper for removing the columns is also provided, to be used in the `down` method of migrations.
-