1. 06 Feb, 2020 1 commit
    • Stan Hu's avatar
      Redact push options from error logs · 6a6b5d8c
      Stan Hu authored
      When an error creating a pipeline occurs, we log all the pipeline
      parameters, including the push options, in an error log and in
      Sentry. However, since push options are flattened into unique keys
      (e.g. `merge_request.label=gitlab-ci`, `ci.variable.MY_VARIABLE=test`),
      it's easy to generate many unique keys, which may exceed the
      Elasticsearch limit of 1000.
      
      To avoid this from happening, this commit drops the `push_options` field
      from the log. These generally shouldn't be needed to understand why
      a pipeline failed to create.
      
      Closes https://gitlab.com/gitlab-org/gitlab/issues/202129
      6a6b5d8c
  2. 05 Feb, 2020 39 commits