- 19 Jun, 2019 31 commits
-
-
pjaspers authored
So funny story, true story. I tried to run the test locally, but didn't make it past setting up Gitaly. Here's what I tried: First attempt: `git clone gitlab-ce` `cd gitlab-ce && bundle install` `be rspec` This didn't work because I was missing the config/database.yml, I didn't see a `script/bootstrap` so I looked in the readme which redirected me to a webpage which redirected me to the gitlab-development-kit. Second attempt: `gem install gitlab-development-kit` cd gitlab-development-kit gdk init gdk isntall This broke somwhere along the way because it couldn't install Gitaly because my go version was too low. But it did clone the gitlab repo again and this time it did have a config/database.yml. So I tried to cd into it and `be rspec spec/lib/gitlab/database/migration_helpers_spec.rb` which complained about the database not being configured so I: - Changed the socket to localhost (in the config/database.yml) - `createdb <dev_db>` `createdb test_db` - `be rake db:test:prepare` Great success, it was doing things! But then failed when it came at the Gitaly step. Since I only want to change these three lines, at the point I gave up and entrusted the pipeline to do its thing. What I would have liked: - A 'It's a Rails system, I know this' readme/docs (It's in there somewhere just couldn't find it) - A way to run tests without having to use Gitaly - Not having too install all the things for a small fix (I get why'd you want this, but to me it's overkill)
-
pjaspers authored
The rather cryptic: "fk_#{Digest::SHA256.hexdigest("#{table}_#{column}_fk").first(10)}" Was too much for emacs too handle*, since it was coming from the Rails codebase I took their way of doing the same thing and applied it here. I think it's easier to read and it also makes emacs render the migration helpers pretty again. * not true, emacs can handle anything, leave emacs alone!
-
Sanad Liaquat authored
Unquarantine the branches E2E test Closes gitlab-org/quality/nightly#62 See merge request gitlab-org/gitlab-ce!29828
-
Achilleas Pipinellis authored
Docs: Added source upgrade guides for 12.0.0 See merge request gitlab-org/gitlab-ce!29795
-
Achilleas Pipinellis authored
Document Usage Quotas group settings page Closes #63022 See merge request gitlab-org/gitlab-ce!29599
-
Alessio Caiazza authored
-
Achilleas Pipinellis authored
Add zoom call section in issue data page See merge request gitlab-org/gitlab-ce!29815
-
Kamil Trzciński authored
Add changelog entry for the new operations_feature_flags_clients.token_encrypted column See merge request gitlab-org/gitlab-ce!29820
-
Krasimir Angelov authored
We missed to add this in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29320. Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/57918
-
Ramya Authappan authored
Unquarantine merge tests Closes gitlab-org/quality/nightly#93 and gitlab-org/quality/nightly#94 See merge request gitlab-org/gitlab-ce!29833
-
Achilleas Pipinellis authored
Crosslink Mattermost integrations, simplify components list See merge request gitlab-org/gitlab-ce!29317
-
Joshua Lambert authored
-
James Lopez authored
Allow developers to delete tags Closes #52954 See merge request gitlab-org/gitlab-ce!29668
-
Manoj MJ authored
This commit adds - feature specs - to test the ability of a user with "developer" permission to delete tags in repositories. - documentation
-
James Lopez authored
Fix Container Scanning job with K8S runners Closes gitlab-ee#11448 See merge request gitlab-org/gitlab-ce!29706
-
Philippe Lafoucrière authored
-
Achilleas Pipinellis authored
Add note about not translating API messages. See merge request gitlab-org/gitlab-ce!29748
-
Bob Van Landuyt authored
-
Mark Lapierre authored
-
Jan Provaznik authored
Add identity information to external authorization requests See merge request gitlab-org/gitlab-ce!29461
-
Manoj MJ authored
Issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/61201#
-
Stan Hu authored
Fix missing API notification flags for Microsoft Teams See merge request gitlab-org/gitlab-ce!29824
-
Achilleas Pipinellis authored
Demote new section See merge request gitlab-org/gitlab-ce!29829
-
Evan Read authored
-
Sanad Liaquat authored
Un-quarantine OAuth spec Closes gitlab-org/quality/nightly#100 See merge request gitlab-org/gitlab-ce!29764
-
Seiji Suenaga authored
-
Mark Lapierre authored
-
Seiji Suenaga authored
-
Ash McKenzie authored
Remove support for app label matching See merge request gitlab-org/gitlab-ce!29460
-
Seiji Suenaga authored
-
Ash McKenzie authored
Removes database.yml.example See merge request gitlab-org/gitlab-ce!29822
-
- 18 Jun, 2019 9 commits
-
-
Mayra Cabrera authored
It's an empty file that was committed by accident on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28565
-
Thong Kuah authored
-
Thong Kuah authored
From now on, only match on the annotations, instead of falling back to legacy app label. This enables users to use the app label for other purposes such as helm charts.
-
Thong Kuah authored
Cache feature flag names in Redis for a minute Closes #63435 See merge request gitlab-org/gitlab-ce!29816
-
Evan Read authored
Adds docs for job collapsible sections See merge request gitlab-org/gitlab-ce!29792
-
Filipa Lacerda authored
-
Mayra Cabrera authored
Update response code for container registry api bulk delete Closes #62183 See merge request gitlab-org/gitlab-ce!29448
-
Steve Abrams authored
The bulk delete api endpoint for container registries can only be called once per hour. If a user calls the endpoint more than once per hour, they will now receive a 400 error with a descriptive message.
-
Evan Read authored
Added IP restriction docs to groups See merge request gitlab-org/gitlab-ce!29809
-