- 16 Nov, 2021 40 commits
-
-
Dylan Griffith authored
This was removed in 5ec78473 and I had to add it back because we can't raise exceptions in development for all cross-modifications because so far we've only ensured the allowlist is correct for specs files and don't have inline allows for all the known violations. I was able to see a failure by creating a pipeline with `environment` and it failed with 500. Since we want to be able to enable the feature flag and env var by default we don't want to break everyone's local development experience.
-
Dylan Griffith authored
-
Kamil Trzciński authored
Document 2PC violation related to destroy of user trying to nullify all ci_builds and pipelines.
-
Kamil Trzciński authored
-
Kamil Trzciński authored
This allows to temporarily suppress the analyzer for any purpose in a consistent way.
-
Kamil Trzciński authored
This changes the feature flag to make it much easier to digest when used with conditions.
-
Kamil Trzciński authored
Remove all duplicate processing logic and make it fit well into `rspec`. This requires adding `allow_cross_database_modification` flag.
-
Kamil Trzciński authored
This removes middlewares as they are already provided by the `QueryAnalyzer`
-
Kamil Trzciński authored
This adapts the `PreventCrossDatabaseModification` to latest `QueryAnalyzers` structure. It still does not fix all structural optimisations that can be done.
-
Dylan Griffith authored
-
Dylan Griffith authored
This adds a Rack middleware and Sidekiq middleware for detecting "Cross-database modification" violations. These occur when you query 2 different databases in the context of a single transaction. Previously we only wrapped our RSpec code with this detection logic but we found that it was often causing lots of false positives in RSpec (in test-only code) which made it hard to sort through the real issues. In addition we want extra validation by running this in production and therefore detecting code that our specs may be missing. The middlewares use a feature flag `detect_cross_database_modification` which we intend to enable for a small percentage of time. The middlewares can also be disabled by setting the env var `DISABLE_CROSS_DATABASE_MODIFICATION_DETECTION=true` and restarting the application. This environment variable is an extra safety net if the middlewares are causing problems.
-
Suzanne Selhorn authored
Add new substitution rules relating to roles See merge request gitlab-org/gitlab!74569
-
Evan Read authored
-
Rémy Coutable authored
Fix broken master in `tag_spec.rb` See merge request gitlab-org/gitlab!74636
-
Olena Horal-Koretska authored
Resolve "Undefined code blocks and strange rendering in the Content Editor" See merge request gitlab-org/gitlab!74520
-
Peter Hegman authored
Disallow crawler indexing of Group SSO login page See merge request gitlab-org/gitlab!74227
-
Suzanne Selhorn authored
Update runner documentation with 14.5 UI changes See merge request gitlab-org/gitlab!74165
-
Miguel Rincon authored
-
Andrejs Cunskis authored
Use unique package names in QA specs See merge request gitlab-org/gitlab!74399
-
David Fernandez authored
-
Kamil Trzciński authored
-
Jose Ivan Vargas authored
Make capitalization of incident management objects uniform in modal See merge request gitlab-org/gitlab!74453
-
Peter Leitzen authored
Fix OpenStruct use See merge request gitlab-org/gitlab!74415
-
Jose Ivan Vargas authored
Fix invalid link in empty state of test cases See merge request gitlab-org/gitlab!74621
-
Natalia Tepluhina authored
Detach new and old package registry See merge request gitlab-org/gitlab!74383
-
Nicolò Maria Mezzopera authored
-
Kerri Miller authored
Optimise events count sql and pagination See merge request gitlab-org/gitlab!74062
-
Jose Ivan Vargas authored
Move frontend registry app to packages_and_registries See merge request gitlab-org/gitlab!74507
-
Nicolò Maria Mezzopera authored
-
Etienne Baqué authored
Add member approve_all API endpoint See merge request gitlab-org/gitlab!73849
-
Kerri Miller authored
Fixed outdated diff line service finding wrong diff line index See merge request gitlab-org/gitlab!74389
-
Kerri Miller authored
Enable API v3 `branches/:sha` partial response See merge request gitlab-org/gitlab!74355
-
mehulsharma authored
Fixes OpenStruct use in billing_plans_helper_spec Changelog: other EE: true
-
Sanad Liaquat authored
Fix e2e tests when UI is used to create a top level group See merge request gitlab-org/gitlab!74603
-
Sanad Liaquat authored
-
Matija Čupić authored
Update accessibility template v6.0.1 See merge request gitlab-org/gitlab!73309
-
Maxime Orefice authored
-
Kamil Trzciński authored
Correct loose_foreign_keys_deleted_records schema to gitlab_shared See merge request gitlab-org/gitlab!74586
-
Marcin Sedlak-Jakubowski authored
Change documentation to reflect service desk email visibility See merge request gitlab-org/gitlab!74613
-
Denys Mishunov authored
Add Yaml Source Editor Extension See merge request gitlab-org/gitlab!72764
-