- 05 Oct, 2016 1 commit
-
-
James Lopez authored
-
- 04 Oct, 2016 1 commit
-
-
Valery Sizov authored
-
- 29 Sep, 2016 2 commits
-
-
Ruben Davila authored
-
Ruben Davila authored
-
- 28 Sep, 2016 2 commits
-
-
Ruben Davila authored
-
Jacob Schatz authored
Add missing url param to ajax call The `url` param was missing from the ajax call. This bug happened because the `url` param was not set. jQuery defaults to `location.href`. BUT if the user came to the protected branches page from another page a previously set `ajaxSettings.url` was used as default url (which defaults to `location.href`) so when the user submitted the form the request was made to a completely wrong `url`. Refreshing the page was working because `ajaxSettings.url` was set to the current page'`location.href` and that was the correct URL. This MR ensures the url will always be set with the right one. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/22020 See merge request !760
-
- 26 Sep, 2016 2 commits
-
-
Alfredo Sumaran authored
-
Stan Hu authored
Projects that are in pending_delete could still trigger the mirror, leading to undefined method `mark_import_as_failed` errors and repeated Sidekiq retries.
-
- 24 Sep, 2016 1 commit
-
-
Ruben Davila authored
-
- 23 Sep, 2016 2 commits
-
-
Ruben Davila authored
-
Ruben Davila authored
-
- 22 Sep, 2016 1 commit
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 21 Sep, 2016 4 commits
-
-
Douwe Maan authored
Enforce repository size limit across all projects and groups, includes LFS objects in that limit. Limit can be set globally, and overridden per group, and/or project. Backend functionality is there and comprehensive tests are included, but there is still some frontend work to be done and documentation to be added. I'm submitting early for review as we are close to the release. @DouweM @dbalexandre I'd appreciate it if you both could start with the review while I finish the documentation and the missing frontend parts. /cc @JobV @regisF Fixes #559 Replaces gitlab-org/gitlab-ce!6020 ## Screenshots (see gitlab-org/gitlab-ce!6020 for more)     See merge request !740
-
Douwe Maan authored
Active Directory ranged member retrieval Related to gitlab-org/gitlab-ee!422 See merge request !719
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Drew Blessing authored
-
- 20 Sep, 2016 3 commits
-
-
Robert Speicher authored
Add more usage data to EE ping This MR loads the EE usage ping asynchronously on the admin application settings page and now includes the counts of the following items: * Comments * Groups * Users * Projects * Issues * Labels * CI builds * Snippets * Milestones * Todos * Pushes * Merge requests * Environments * Triggers * Deploy keys * Pages * Project Services * Issue Boards * CI Runners * Deployments * Geo Nodes * LDAP Groups * LDAP Keys * LDAP Users * LFS objects * Protected branches * Releases * Remote mirrors * Web hooks Closes #997 See merge request !735
-
Patricio Cano authored
-
Stan Hu authored
Load it asynchronously to prevent blocking a page load. Closes #997 Add a container around usage data help-block to prevent horizontal scroll in Firefox Closes #808
-
- 16 Sep, 2016 1 commit
-
-
Paco Guzman authored
When we update the flag pending_delete to true and later try to destroy the remote mirror (through association callbacks) the remote mirror try to load the project, but it is out of the default scope so it just return nil. As we need the project to remove the reference to the remote mirror but we’re going to delete the project and its repository is not needed to touch the repository to just remove that reference, so we just skip that step in that case
-
- 14 Sep, 2016 1 commit
-
-
Rémy Coutable authored
[ci skip] Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 13 Sep, 2016 2 commits
-
-
Ahmad Sherif authored
-
Valery Sizov authored
-
- 12 Sep, 2016 3 commits
-
-
Alejandro Rodríguez authored
Because of missing validations in the projects model, you could create a new project with a nil or empty import_url with mirror=true. This would cause exceptions when RepositoryUpdateMirrorWorker::UpdateMirrorError ran and attempted to update one of these projects. This was made easier by the fact that you could show the "Mirror repository" checkbox in the UI, check it, hide it, and still have its value considered. The missing validations have been added, and minor adjustments have been made to the UI to improve the previous behaviour. A migration was also added to update mirror=false in all projects with a nil or empty import url that exists because of the described bug.
-
Drew Blessing authored
-
Valery Sizov authored
-
- 09 Sep, 2016 1 commit
-
-
Alejandro Rodríguez authored
By changing our logic from `before_transition` to `after_transition` blocks and removing extra calls to `update` or `save` we can do all changes in a single UPDATE query (currently each transition change from started -> failed and started -> finished runs two UPDATE queries each)
-
- 08 Sep, 2016 3 commits
-
-
Drew Blessing authored
-
Ahmad Sherif authored
-
Ahmad Sherif authored
-
- 06 Sep, 2016 1 commit
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 05 Sep, 2016 1 commit
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 01 Sep, 2016 1 commit
-
-
Ruben Davila authored
-
- 26 Aug, 2016 4 commits
-
-
Valery Sizov authored
-
Stan Hu authored
Closes gitlab-com/support-forum#946, #934
-
Patricio Cano authored
-
Ruben Davila authored
-
- 25 Aug, 2016 1 commit
-
-
Valery Sizov authored
-
- 23 Aug, 2016 1 commit
-
-
Ruben Davila authored
-
- 20 Aug, 2016 1 commit
-
-
Douwe Maan authored
Restrict pushes / merges to a protected branch to specific people - Closes #674 - Related to #179    - [ ] ee#674 !581 Restrict merges to specific people - [x] Implementation - [x] Model changes - [x] Protected branch `has_many` access levels - [x] Frontend - [x] How to add new users / roles? - [x] Dropdown should include users - [x] Dropdown shouldn't include users / roles that have already been selected - [x] Allow removing users / roles - [x] Removing a user from the project should remove their access (?) - [x] Test/refactor - [x] Extract common from {Merge,Push}AccessLevel models - [x] Clean up code that's removing users/roles that are already selected - [x] AccessLevelController? - [x] Fix build - [x] Add more tests - [x] Non `:push_code` users can't push even if added to an access level - [x] Remove access levels when a user is removed from a project - [x] Rebase off EE master instead of the "no one can push" feature branch - [x] Fix create for roles - [x] Fix update for roles - [x] Fix delete - [x] Fix create for users - [x] Fix update for users - [x] Fix defaults - [x] Verify - [x] API - [x] For a developer user - [x] When they are granted access specifically to - [x] Merge - [x] Push - [x] For a reporter user - [x] When they are granted access specifically to - [x] Merge - [x] Push - [x] Default branch protection - [x] CHANGELOG - [x] Screenshots - [x] Only show `:push_code` users in the dropdown - [x] Send email when user is added/removed from a protected branch - [x] Assign to {mini,end}boss - [x] Fix build - [x] Implement @dbalexandre's review comments - [x] EE should _add_ to CE - [x] Wait for [build](https://gitlab.com/gitlab-org/gitlab-ee/commit/61edf43d31452a0b972dc880e277c825d59f764f/builds) to pass - [x] Test by hand - [x] Assign to endboss - [x] Create CE MR to backport changes - [x] Implement @Douwe's comments - [x] access_level#humanize - [x] Blank line in _protected_branch.html.haml - [x] move stuff into shared partials? (_protected_branch_ee.html.haml) - [x] Can we move stuff into shared partials? (_create_protected_branch_ee.html.haml) - [x] The CE version has a bunch of extra attributes here, do we need those? - [x] We can't indent this section just in EE (protected_branches/show.html.haml) - [x] In EE, try not to add stuff to existing views. (protected_branches/show.html.haml) - [x] If we're gonna change multiline blocks to single-line blocks, we need to so in CE too. (factory) - [x] Split up `ProtectedBranches#show` - [x] Wait for [build](https://gitlab.com/gitlab-org/gitlab-ee/commit/3943254d5f92c9be520f685044d23bf75282d42a/builds) - [x] Implement Douwe's suggestions - [x] Add uniqueness validation - [x] Wait for @alfredo's UI enhancements - [x] Remove `show` page access controls - [x] Add more feature specs - [ ] Wait for review for @alfredo's work - [ ] Wait for merge See merge request !581
-