- 19 May, 2020 1 commit
-
-
Mehmet Emin INAC authored
Currently Occurrence#_feedback methods return an instance of BatchLoader which mimics almost all the behaviour of proxied object but it's not perfect. We can't use safe navigation operator on these return objects because they are not actually `nil` since the Ruby VM just checks the object to see if it's `NIL_P` before sending the message. This causes getting NoMethodError on nil:NilClass which causes tears on developers' eye. Here we are explicitly returning an instance of Feedback model and also loading all the feedback of all occurrences which solves the hidden N+1 query issue.
-
- 18 May, 2020 39 commits
-
-
Martin Wortschack authored
Merge branch 'update-deprecated-slot-syntax-in-./app/assets/javascripts/ide/components/pipelines/list.vue' into 'master' Update deprecated slot syntax in `./app/assets/javascripts/ide/components/pipelines/list.vue` See merge request gitlab-org/gitlab!32027
-
Gilang Gumilar authored
-
Heinrich Lee Yu authored
Move `derailed_benchmarks` into `test` group Closes #217527 See merge request gitlab-org/gitlab!32169
-
Adam Hegyi authored
Add epic_id to resource_state_events See merge request gitlab-org/gitlab!31587
-
Mike Jang authored
Add docs about group push rules See merge request gitlab-org/gitlab!25282
-
Sean McGivern authored
25875-Add-Webex-Teams-project-integration-service Closes #25875 See merge request gitlab-org/gitlab!31543
-
Rémy Coutable authored
Testing migration path for major upgrades - bump to testing 12->13 upgrades. See merge request gitlab-org/gitlab!32302
-
Mike Greiling authored
Merge branch 'update-deprecated-slot-syntax-in-./app/assets/javascripts/performance_bar/components/detailed_metric.vue' into 'master' Update deprecated slot syntax in `./app/assets/javascripts/performance_bar/components/detailed_metric.vue` See merge request gitlab-org/gitlab!32006
-
Gilang Gumilar authored
Update deprecated slot syntax in `./app/assets/javascripts/performance_bar/components/detailed_metric.vue`
-
Mark Florian authored
Add first draft of revised CSS documentation See merge request gitlab-org/gitlab!31963
-
Sarah Groff Hennigh-Palermo authored
-
Patrick Derichs authored
With foreign key to epics and index on epic_id
-
Clement Ho authored
Merge branch 'update-deprecated-slot-syntax-in-./app/assets/javascripts/ide/components/ide_review.vue' into 'master' Update deprecated slot syntax in `./app/assets/javascripts/ide/components/ide_review.vue` See merge request gitlab-org/gitlab!32025
-
Gilang Gumilar authored
-
Kamil Trzciński authored
Enable project ndjson ff by default Closes #216959 See merge request gitlab-org/gitlab!31601
-
Sean McGivern authored
Merge branch 'master' of gitlab.com:gitlab-org/gitlab into 25875-Add-Webex-Teams-project-integration-service
-
Sean McGivern authored
Add `uploaded_files` param to Snippet create mutation See merge request gitlab-org/gitlab!32309
-
Marcel Amirault authored
Add notice about instance variables limitation See merge request gitlab-org/gitlab!32410
-
Marius Bobin authored
-
Stan Hu authored
Skip Redundant Persistent Ref existence check See merge request gitlab-org/gitlab!32391
-
Marcia Ramos authored
Update title for error handling in Go See merge request gitlab-org/gitlab!32374
-
Mark Florian authored
Merge branch '22691-externelize-i18n-strings-from-./app/views/shared/_recaptcha_form.html.haml' into 'master' Externalize i18n strings from ./app/views/shared/_recaptcha_form.html.haml See merge request gitlab-org/gitlab!32106
-
Gilang Gumilar authored
In app/views/shared/_recaptcha_form.html.haml.
-
Peter Leitzen authored
Rename variables to increase tests readability Closes #216937 See merge request gitlab-org/gitlab!32114
-
Peter Leitzen authored
Geo: `Replicator.for_replicable_name` should raise (and log) NotImplementedError Closes #217029 See merge request gitlab-org/gitlab!31388
-
Grzegorz Bizon authored
Refactor ci minutes progress bar - pt2 See merge request gitlab-org/gitlab!30467
-
Fabio Pitino authored
Move some of the logic from NamespacesHelper into new class and implement related methods from Namespace and NamespaceStatistics.
-
Sean McGivern authored
Update info message when project and group messages are started Closes #213424 See merge request gitlab-org/gitlab!31981
-
Bob Van Landuyt authored
Merge branch '217600-vulnerability-feedback-is-missing-for-vulnerability-occurrences-that-promoted-to-first-class' into 'master' Fix missing dismissed_by_id field for Vulnerabilities See merge request gitlab-org/gitlab!32147
-
Mark Florian authored
Update avatar_helper to accept GraphQL id See merge request gitlab-org/gitlab!32261
-
Rémy Coutable authored
Fix/shebang See merge request gitlab-org/gitlab!32371
-
Peter Leitzen authored
Managed applications template artifact See merge request gitlab-org/gitlab!29870
-
Vitali Tatarintev authored
-
Craig Norris authored
Add codeowners for /ci and /.linting docs directories See merge request gitlab-org/gitlab!32387
-
Rémy Coutable authored
Add nested file detection for Dependency Scanning See merge request gitlab-org/gitlab!31932
-
Igor Frenkel authored
-
Marcia Ramos authored
Docs: Add suggested copy-edits for x509 rake task Closes #214417 See merge request gitlab-org/gitlab!32393
-
Thong Kuah authored
-
Marcin Sedlak-Jakubowski authored
Issue and epic drag and drop tier fix See merge request gitlab-org/gitlab!32297
-