1. 02 Mar, 2020 5 commits
    • Thong Kuah's avatar
      Fix N+1 in milestone show page · 99416b5e
      Thong Kuah authored
      The issue is that using becomes means a new object is instantiated all
      the time, which means we throw away the route preload for the namespace
      
      In fact, we don't even need to pass in the namespace for the polymorphic
      route, the issuable_path helper seems to be able to figure out the
      correct path just from the project.
      
      Adds test for n+1 for group milestone show page. We are loading the
      route for the namespace for each issue for the milestone.
      
      Also, use the same link for both issue links
      
      Also, removes @project_namespace definition as nothing use it anymore
      99416b5e
    • Thong Kuah's avatar
      Add view spec against regression · b63ae5ac
      Thong Kuah authored
      Add spec to make sure that the
      app/views/shared/milestones/_issuable.html.haml continues to work as
      expected.
      b63ae5ac
    • Thong Kuah's avatar
      Wrap test inside describe block · 7c3f7412
      Thong Kuah authored
      Also fix path construction to use path helper
      7c3f7412
    • Thong Kuah's avatar
      Merge branch 'sh-fix-sidekiq-reload-errors' into 'master' · 97624108
      Thong Kuah authored
      Fix Sidekiq code reloading
      
      See merge request gitlab-org/gitlab!26237
      97624108
    • Evan Read's avatar
      Merge branch 'docs-aqualls-oxford' into 'master' · 785a8b41
      Evan Read authored
      Docs: fix missing Oxford commas
      
      See merge request gitlab-org/gitlab!26207
      785a8b41
  2. 01 Mar, 2020 10 commits
  3. 29 Feb, 2020 23 commits
  4. 28 Feb, 2020 2 commits