- 16 Sep, 2020 40 commits
-
-
Alex Kalderimis authored
-
Alex Kalderimis authored
This is a bit more acceptable: just under 2min, and 1175 examples.
-
Alex Kalderimis authored
This includes a bunch of optimizations (avoiding re-creating issues, being very careful about resets) that means we can run over a range of size 6 (2606 examples) in about 4min 30s.
-
Alex Kalderimis authored
We want the `new_item` to be a new, unplaced item. We have made `move_sequence` a private method, so we need to call it using send.
-
Alex Kalderimis authored
-
Alex Kalderimis authored
-
Alex Kalderimis authored
The RelativePositioning::Range class is reponsible for inferring the other end of ranges, testing if the range is open and detecting if an object is contained within the range (allowing us to avoid some operations).
-
Alex Kalderimis authored
-
Alex Kalderimis authored
This divides up the relative_positioning class specs into the appropriate places in the lib tree
-
Alex Kalderimis authored
This moves Mover, ItemContext and Gap into the lib tree where they can be used separately from the app code.
-
Alex Kalderimis authored
-
Alex Kalderimis authored
The changes tested here are to see if in EE projects in the same groups count as part of the same relative positioning set. We do not need to test every method - just the scoping query. Frankly a bunch of the movement tests could also be removed, but they are all calling public methods so it is fine for them to test the interface.
-
Alex Kalderimis authored
-
Alex Kalderimis authored
This is now part of the usage instructions in the relative positioning shared examples.
-
Alex Kalderimis authored
Since classes that include RelativePositioning no longer can override low-level implementation methods to hook into internal details, this means that catching query timeouts and other failures systematically is no longer straightforward. This change allows classes to implement a new callback hook: `#could_not_move`, which is called with an exception if any of the movement methods times out.
-
Alex Kalderimis authored
-
Alex Kalderimis authored
-
Alex Kalderimis authored
This involves custom handling for polymorphic models, and null-safety.
-
Alex Kalderimis authored
Hetrogenous sets of items need to override a couple of methods
-
Alex Kalderimis authored
These are tested by their behavior
-
Alex Kalderimis authored
-
Alex Kalderimis authored
By testing this, we can remove the tests on private members.
-
Alex Kalderimis authored
-
Alex Kalderimis authored
this comes at the cost of less-than-correct behaviour See: https://gitlab.com/gitlab-org/gitlab/-/issues/238416
-
Jan Provaznik authored
[Relative Positioning] Correct sibling query for epic tree nodes See merge request gitlab-org/gitlab!41986
-
Sean McGivern authored
Expose dependency path See merge request gitlab-org/gitlab!40644
-
Tetiana Chupryna authored
Add mock data
-
Marcin Sedlak-Jakubowski authored
Add docs for custom schema validation See merge request gitlab-org/gitlab!42194
-
Himanshu Kapoor authored
Outside the Syntax highlighting header as per: https://gitlab.com/gitlab-org/gitlab/-/issues/247483#note_413000624
-
Dmytro Zaporozhets (DZ) authored
Track projects using code intelligence See merge request gitlab-org/gitlab!41881
-
Mike Greiling authored
Don't apply Ctrl markdown shortcuts on Mac See merge request gitlab-org/gitlab!42239
-
Enrique Alcántara authored
Update buttons in the Add issues modal in Boards Closes #229321 See merge request gitlab-org/gitlab!42317
-
Marcin Sedlak-Jakubowski authored
Add note for red merge button to MR docs Closes #245329 and #245326 See merge request gitlab-org/gitlab!41608
-
Daniel Gruesso authored
-
Kushal Pandya authored
Add tracking to group invite banner Closes #219240 and #229619 See merge request gitlab-org/gitlab!41774
-
Gabriel Mazetto authored
Projects::CreateService to consider only group membership for admin See merge request gitlab-org/gitlab!42335
-
Enrique Alcántara authored
Remove remaining deprecated GlNew references See merge request gitlab-org/gitlab!42422
-
Gabriel Mazetto authored
Don't clean Sidekiq processes when fetching metrics See merge request gitlab-org/gitlab!42463
-
Mike Jang authored
Docs: Clarify definition of subject See merge request gitlab-org/gitlab!42445
-
Thong Kuah authored
-