- 02 Jan, 2020 21 commits
-
-
Mike Kozono authored
It helps run exactly one instance of a worker, over and over, until it returns false or raises. If `perform` completes very quickly, it will sleep until `minimum_duration` is reached (default 5 seconds).
-
Clement Ho authored
Migrate deployment_instance_spec.js spec to jest See merge request gitlab-org/gitlab!22169
-
Sean McGivern authored
Remove ignored columns from Plan model See merge request gitlab-org/gitlab!22302
-
Jan Provaznik authored
Optimize Group#for_epics scope Closes #37368 and #37748 See merge request gitlab-org/gitlab!22375
-
Martin Wortschack authored
Fix tests failing in async mode Closes #193491 See merge request gitlab-org/gitlab!22361
-
Illya Klymov authored
This commit adds sync: false to our tests, preparing for VTU upgrade
-
Enrique Alcantara authored
- ee/spec/javascripts/environments/deploy_board_component_spec.js - ee/spec/javascripts/vue_shared/components/deployment_instance_spec.js
-
Jan Provaznik authored
Prevent stack overflowing with a lot of user references Closes #119333 See merge request gitlab-org/gitlab!22247
-
Martin Wortschack authored
Replace search by stub name with real components Closes #191270 See merge request gitlab-org/gitlab!22300
-
Kushal Pandya authored
Add support for operator in filter bar See merge request gitlab-org/gitlab!19011
-
Andreas Brandl authored
Drop redundant index on ci_pipelines.project_id See merge request gitlab-org/gitlab!22325
-
Sean McGivern authored
When an issue, MR, or epic contains a lot of user references (even to the same user), we use the method Banzai::ReferenceParser::BaseParser.collection_objects_for_ids to load those users and maintain the loaded users for the current request in a RequestStore cache. This method calls Hash#values_at with the splatted IDs - so one argument per ID passed in. If enough IDs are passed in, it's possible for the arguments here to overflow the stack. Let's say we have: ids = [1] * 1_000_000; ids.length #=> 1000000 cache = {} #=> {} cache.values_at(*ids).compact # SystemStackError: stack level too deep We could do this `cache.values_at(*ids.uniq).compact`, but that would fail in this case: distinct_ids = 1.upto(1_000_000).to_a; distinct_ids.length #=> 1000000 cache.values_at(*distinct_ids.uniq).compact # SystemStackError: stack level too deep So the best option seems to be to just write a slower, but non-stack-consuming, version: Benchmark.realtime { ids.uniq.map { |id| cache[id] }.compact } #=> 0.15192799968644977 Benchmark.realtime { distinct_ids.uniq.map { |id| cache[id] }.compact } #=> 0.3621319998055696 To test this locally, you can replace the last issue's description with a lot of mentions of a user (here I've created a user with the username 't'), but it takes a long time: problem = ('@t ' * 1_000_000)[0...1_000_000]; problem.length #=> 1000000 Issue.last.update!(description: problem_string) Visiting that issue in the UI will then overflow the stack. With this change, it won't (although it is very slow).
-
Lin Jen-Shin authored
Pass through TOP_UPSTREAM_SOURCE_REF for qa pipeline See merge request gitlab-org/gitlab!22263
-
Adam Hegyi authored
Remove optimized_groups_user_can_read_epics_method feature flag and keep the optimized code in the codebase. Closes https://gitlab.com/gitlab-org/gitlab/issues/37748
-
Martin Wortschack authored
Fix shallowMount + stubs behavior change in `@vue/test-utils` Closes #145615 See merge request gitlab-org/gitlab!22286
-
Martin Wortschack authored
Provide proper mock data for test Closes #191453 See merge request gitlab-org/gitlab!22316
-
Martin Wortschack authored
Replace trigger with emit in test Closes #191430 See merge request gitlab-org/gitlab!22315
-
Illya Klymov authored
Make sure we are searching components by reference Not by generated stub name
-
Jan Provaznik authored
Test for no offenses only makes sense with offense See merge request gitlab-org/gitlab!22301
-
Mark Lapierre authored
Add ajax wait for requests Closes #55286 See merge request gitlab-org/gitlab!22291
-
Ash McKenzie authored
Stop exposing MR refs in favor of persistent pipeline refs Closes #35918 and #35140 See merge request gitlab-org/gitlab!22198
-
- 01 Jan, 2020 8 commits
-
-
Sean McGivern authored
Add weight change tracking See merge request gitlab-org/gitlab!21515
-
Shinya Maeda authored
This commit fixes the inconsistent behavior of MR refs
-
Kushal Pandya authored
Resolve "Users in Personal trials should be able to upgrade" See merge request gitlab-org/gitlab!22270
-
Kushal Pandya authored
Add nextTick to setData calls for Jest tests Closes #38108 See merge request gitlab-org/gitlab!22232
-
Kushal Pandya authored
Fix karma tests in future version of VTU See merge request gitlab-org/gitlab!22358
-
Kushal Pandya authored
Always invoke find on updated Vue tree Closes #181842 See merge request gitlab-org/gitlab!22288
-
Kushal Pandya authored
Wrap trigger into nextTick calls Closes #192019 See merge request gitlab-org/gitlab!22324
-
Kushal Pandya authored
Remove spinner when approval require input is changed Closes #38090 See merge request gitlab-org/gitlab!22186
-
- 31 Dec, 2019 11 commits
-
-
Mike Lewis authored
Documentation for pages size Limitations by Project or Group See merge request gitlab-org/gitlab!22334
-
Vladimir Shushlin authored
-
Patrick Derichs authored
Write system note if weight tracking feature flag is not set Make comment more generic Fix scope for SystemNoteMetadata constructor call and add specs Add specs and fix missing include on ResourceWeightEvent Fix schema.rb on_delete clause Add specs for note count by feature flag Add specs for services
-
Kushal Pandya authored
Cut and paste Markdown table from a spreadsheet Closes #27205 See merge request gitlab-org/gitlab!22290
-
Kushal Pandya authored
Wait for axios mock in spec Closes #122859 See merge request gitlab-org/gitlab!22285
-
Illya Klymov authored
Update spec to properly wait for promise to resolve
-
Stan Hu authored
Upon pasting to a Markdown input, this commit will try to detect whether a spreadsheet has been copied to the clipboard and automatically create a Markdown table. This is based off code from https://github.com/jonmagic/copy-excel-paste-markdown. Closes https://gitlab.com/gitlab-org/gitlab/issues/27205
-
Sean McGivern authored
Add option to configure branches for which emails should be sent on push See merge request gitlab-org/gitlab!22196
-
Illya Klymov authored
Fix trigger calls
-
Balasankar "Balu" C authored
Signed-off-by: Balasankar "Balu" C <balasankarc@autistici.org>
-
Illya Klymov authored
Fixes failing tests in @vue/test-utils 1.0.0-beta.30
-