- 01 Feb, 2021 40 commits
-
-
Alex Kalderimis authored
-
Alex Kalderimis authored
GraphQL does not have inheritance, so it is an anti-pattern to use it to model polymorphism in our models. The correct approach is to model polymorphism as implementation of interfaces. Here there is a single `PackageType` interface, and then different implementations of that. Since the package types only differ in their metadata, we move the polymorphism down to the metadata fields, which an empty interface, implemented by metadata types. One thing that had to change was the `Query.package` field, which was previously `Query.package_composer_details`. This must change since the implementation of the lookup does not perform any type checking, and thus we cannot type the return value as a composer package. This would be an illegal and ill-typed down-cast. A good analogy for this is having a Java collection of ```java // yes, Cucumbers are fruits - look it up List<Fruit> bowl = List.of(new Apple(), new Banana(), new Cucumber()) ``` And then expecting to get an apple without a cast: ```java Apple fruit = bowl.get(0) // bad ``` This code would fail to compile in Java, and it is equally illegal in GraphQL, without the appropriate casting. We mark the composer metadata type as an orphan since it is only refered to as an implementation of the broader metadata type. We also split the type of packages into a top-level one, which is able to refer to versions, and a leaf node which may not. This prevents unbounded mutual cyclic recursion. Return successfully for all packages We can gradually add more specific package types, but it is important to always succeed with the data we can return.
-
Savas Vedova authored
Fix border bottom color collapsed replies See merge request gitlab-org/gitlab!51871
-
Yogi authored
-
Dmytro Zaporozhets (DZ) authored
Merge branch '299462-create-issue-from-vulnerability-details-edited-text-is-discarded' into 'master' Do not overwrite fields that are populated See merge request gitlab-org/gitlab!52376
-
Jonathan Schafer authored
-
Heinrich Lee Yu authored
Add attributions for repository push flag definition See merge request gitlab-org/gitlab!52399
-
Dan Jensen authored
This adds MR, issue, milestone and group details to the definition for the repository_push_audit_event feature flag.
-
🤖 GitLab Bot 🤖 authored
Update Gitaly version See merge request gitlab-org/gitlab!53027
-
Dmytro Zaporozhets (DZ) authored
Add the Manage::Import total GMAU metric See merge request gitlab-org/gitlab!51496
-
Arturo Herrero authored
Add click tracking to in product marketing email campaigns See merge request gitlab-org/gitlab!52723
-
Phil Hughes authored
Use mock-apollo-provider in SAST UI tests See merge request gitlab-org/gitlab!52897
-
Mark Florian authored
Using mock-apollo-provider results in a more realistic test, since the internals of the component(s) (i.e., `data`) aren't manipulated by the test suite. This change also removed an unnecessary use of `localVue` in a related test suite, and moved the SAST spec helpers up a level in the tree. Addresses https://gitlab.com/gitlab-org/gitlab/-/issues/249556.
-
GitLab Release Tools Bot authored
-
Dmytro Zaporozhets (DZ) authored
Update snapshot worker arguments See merge request gitlab-org/gitlab!52785
-
Matthias Käppler authored
Make LifecycleEvents exceptions to be fatal See merge request gitlab-org/gitlab!52881
-
Sean McGivern authored
Monitor RackAttack redis usage and enrich auth structured logs See merge request gitlab-org/gitlab!52471
-
Vitali Tatarintev authored
Oncall-Rotations: Persist shifts job See merge request gitlab-org/gitlab!50239
-
Sean Arnold authored
- Queue files and barebone jobs
-
Russell Dickenson authored
Delete old redirect files in doc/ci, install, ops, telemetry See merge request gitlab-org/gitlab!52993
-
Marcel Amirault authored
These redirect files have expired and we no longer need to maintain them. Server-side redirects will remain in the gitlab-docs project
-
David Fernandez authored
Enable specialized_project_authorization_worker feature flag See merge request gitlab-org/gitlab!52719
-
Heinrich Lee Yu authored
Merge branch '300520-foss-test-failure-feature_available-expected-2-arguments-but-given-1' into 'master' Resolve "FOSS test failure - feature_available? expected 2 arguments but given 1" [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!53003
-
Bob Van Landuyt authored
Improve highlighting for merge diffs See merge request gitlab-org/gitlab!52499
-
Bob Van Landuyt authored
Process one record at a time in Bulk Import pipelines See merge request gitlab-org/gitlab!52330
-
Nick Thomas authored
Update reduce repo size documentation See merge request gitlab-org/gitlab!52734
-
Greg Myers authored
-
Heinrich Lee Yu authored
Merge branch 'mwaw/273391-extract-product-analytics-metrics-aggregation-out-of-hllrediscounter-module' into 'master' Extract Product Analytics metrics aggregation out of HLLRedisCounter module See merge request gitlab-org/gitlab!52334
-
Pavel Shutsin authored
-
Vitali Tatarintev authored
Update gitlab-experiment to version 0.4.8 [RUN ALL RSPEC] See merge request gitlab-org/gitlab!52824
-
Matthias Käppler authored
Do not interpret escaped markdown as shortcuts (like `@` and `#`) See merge request gitlab-org/gitlab!45922
-
Brett Walker authored
so they don’t get confused as references
-
Bob Van Landuyt authored
Expose if user is a bot See merge request gitlab-org/gitlab!52003
-
Tetiana Chupryna authored
-
Bob Van Landuyt authored
Add OpenSearch for GitLab See merge request gitlab-org/gitlab!52583
-
Heinrich Lee Yu authored
Introduce a rendering limit for commit titles See merge request gitlab-org/gitlab!52904
-
Matthias Käppler authored
Merge branch '223618-project-labels-api-return-404-label-not-found-if-label-name-contains-dot' into 'master' Project labels API returns error if label name contains dot "." See merge request gitlab-org/gitlab!52591
-
Brett Walker authored
For example, a label such as `v.1` should be allowed
-
Natalia Tepluhina authored
Sort JS imports in the EE code See merge request gitlab-org/gitlab!52977
-
Vitaly Slobodin authored
Sort JavaScript imports in the EE code to match our future ESLint configuration.
-