- 06 Apr, 2020 1 commit
-
-
Stan Hu authored
NOTE: The upgrade is backwards compatible with existing sessions, but the upgrade of redis-rack v2.1.2 changed Redis keys from `session:gitlab:<random hex value>` to `session:gitlab:2::<hash of hex value>`. If a session does not have a key in the new schema, it will be created transparently. The old session key will eventually be expired automatically. To upgrade to rack 2.0.9, we need to do the following: 1. Fix ActiveSession to use new Rack::Session::SessionId 2. Add a monkey patch for ActionController::TestSessionPatch Controller tests were failing without the changes in https://github.com/rails/rails/pull/38063, which is available on the Rails `6-0-stable` branch but not in Rails 6.0.2.2. 3. Remove CGI escaping of ActiveSession keys. This was not needed because CGI escaping was already being done by Rails. 4. Fix deletion of Rack session keys with ActiveSession redis-rack v2.1.2 changed the session key from one based on the public ID to the private ID. We need to adapt ActiveSession to delete both versions of the key to clear out old data and to make it work with the redis-rack key name changes.
-
- 03 Apr, 2020 39 commits
-
-
Mayra Cabrera authored
Merge branch '212654-can-we-remove-the-index-index_ci_builds_on_name_for_security_reports_values' into 'master' Remove ci_builds security job values index See merge request gitlab-org/gitlab!28224
-
Mayra Cabrera authored
Move 26302 changelog to changelogs See merge request gitlab-org/gitlab!28821
-
Andrew Fontaine authored
Allow users to assign a serverless domain to Knative (frontend) See merge request gitlab-org/gitlab!28431
-
Mayra Cabrera authored
Consume remaining LinkLFsObjectsProjects jobs See merge request gitlab-org/gitlab!27558
-
Paul Slaughter authored
Added shared Clone Dropdown button component See merge request gitlab-org/gitlab!28781
-
Paul Slaughter authored
Fixes flaky spec in`spec/frontend/ide/components/merge_requests/list_spec.js` See merge request gitlab-org/gitlab!28807
-
Ash McKenzie authored
Refactor UpdateDashboardService tests See merge request gitlab-org/gitlab!28376
-
Robert Speicher authored
Find or initialize instance-level integration See merge request gitlab-org/gitlab!28592
-
Clement Ho authored
Update dependency @gitlab/ui to v11.0.1 See merge request gitlab-org/gitlab!28830
-
Denys Mishunov authored
Shared component used for cloning functionality on Projects and Snippets. Also a new shared 'getBaseProtocol' url utility has been added
-
Mike Greiling authored
-
Mike Greiling authored
-
Paul Slaughter authored
Resolve "Remove "Open in file view" in Web IDE" Closes #199081 See merge request gitlab-org/gitlab!28705
-
Martin Wortschack authored
Added snowplow tracking to change direction See merge request gitlab-org/gitlab!28717
-
Mayra Cabrera authored
Issue #26426 Drafting a solution for the retrieval of runners that belong to... See merge request gitlab-org/gitlab!24169
-
Nacho Otal authored
Issue #26426 Drafting a solution for the retrieval of runners that belong to subgroups for the owner of the parent group Issue #26426 : Using the owned_groups with self_and_descendants to get all the groups that a user owns even per inheritance of ownership. Fixing the test case so that it behaves as expected. Issue #26426 : No need to have two separate cases for group_runners and subgroup_runners since the subgroups inherit the ownership from the groups. Issue #26426 : Improving description of the example. Issue #26426 : As discussed, get rid of the example extraction and inline it in the test case. Issue #26426 : As discussed, adding a test case for inclusion of runners that belong to groups in which the user is maintainer (and developer). issue #26426 : Adding reporter and guest to shared examples for completion. Issue #26426 : Adding multi-owner, group owner and project owner as shared examples. Issue #26426 : Refining the case of group owner. Issue #26426 : Making all let imperative. Reviewing the cases so that they're complete. Issue #26426 : Improving wording on the descriptions of the test. Adding completion cases tests.
-
lauraMon authored
* Removes all instances of mocked throttle from spec * Removes all instances of mocked debounce from specs * Adds global helper
-
Douglas Barbosa Alexandre authored
Change organization field to `readonly` for GitLab employees See merge request gitlab-org/gitlab!28151
-
Paul Slaughter authored
Tweak Dependency List pipeline subheading text See merge request gitlab-org/gitlab!28665
-
Mark Florian authored
This also takes the opportunity to switch to `GlSprintf` for i18n. Part of [Update dependencies table UI][1]. [1]: https://gitlab.com/gitlab-org/gitlab/-/issues/195928
-
Michael Kozono authored
Show error when Jira did not return any projects See merge request gitlab-org/gitlab!28752
-
Jarka Košanová authored
-
Dmytro Zaporozhets authored
Change group policy for Group Activity Analytics See merge request gitlab-org/gitlab!28646
-
Aakriti Gupta authored
Only allow users who have access to the group, to be able to access the analytics
-
GitLab Bot authored
-
Denys Mishunov authored
Update dependency @gitlab/svgs to v1.117.0 See merge request gitlab-org/gitlab!28570
-
Andrew Fontaine authored
Change redo for retry icon in metrics dashboard See merge request gitlab-org/gitlab!28670
-
peterhegman authored
Changelog not needed for MRs behind feature flags
-
peterhegman authored
`gitlab_employee?` and `:gitlab_employee_badge` were being used together in multiple places. This combines them into one source of truth. It also allows us to clean up the HAML templates.
-
Douglas Barbosa Alexandre authored
Expose Enabled Replication to API See merge request gitlab-org/gitlab!28478
-
peterhegman authored
-
peterhegman authored
Test organization field attributes and `:gitlab_employee_badge` feature flag
-
peterhegman authored
The organization field will be prepopulated with `GitLab` and readonly for users with a `@gitlab.com` email
-
Andrew Fontaine authored
FE Remove redundant mocking docs See merge request gitlab-org/gitlab!28056
-
Lucas Charles authored
-
Mike Greiling authored
-
Mike Greiling authored
-
Igor Drozdov authored
Remove incomplete and duplicate spec from changelog specs See merge request gitlab-org/gitlab!28801
-
Rajendra Kadam authored
-