- 17 Apr, 2019 9 commits
-
-
GitLab Bot authored
-
Lin Jen-Shin authored
Fix logic in Api::Internal test See merge request gitlab-org/gitlab-ce!27193
-
GitLab Bot authored
-
Grzegorz Bizon authored
Allow extra args for helm in Auto-DevOps See merge request gitlab-org/gitlab-ce!26838
-
GitLab Bot authored
-
Michael Kozono authored
[CE backport] Fix no assignee text in sidebar_spec See merge request gitlab-org/gitlab-ce!27444
-
Michael Kozono authored
Fix no assignee text in sidebar_spec Closes #11192 See merge request gitlab-org/gitlab-ee!11099
-
Michael Kozono authored
Use max of approvals_before_merge between project and MR at runtime Closes #10909 and #10055 See merge request gitlab-org/gitlab-ee!10766
-
Mark Chao authored
Previously, MR#approvals_before_merge is nil when it is <= project (from `clamp_approvals_before_merge`). This changed in f480d145, which would always persist a min value. This caused regression that updating MR would fail if project's value is increased later on. The relationship between value being nil and validation can be easily overlooked. Removing validation and taking the max of the two makes logic clearer.
-
- 16 Apr, 2019 31 commits
-
-
Luke Bennett authored
-
Luke Bennett authored
-
Luke Duncalfe authored
The intention of this test is to ensure that the service class MergeRequests::PushOptionsHandlerService does not run when the :mr_push_options feature flag is disabled. This test was passing, however was not testing what it was supposed to be! For one, setting Feature.disable(:feature) in the test does not disable the feature, as rspec config in spec_helper stubs Feature to make all features enabled: https://gitlab.com/gitlab-org/gitlab-ce/commit/3ee48e422defaedd69946c607bd8d3672e510375 So the feature was still enabled in the test. But this test wasn't failing because unfortunately I had put: ``` expect(MergeRequests::PushOptionsHandlerService).to receive(:new) ``` instead of not_to! This meant that the `.new` method was being stubbed, so the service class did not create a MergeRequest, which satisfied the second expectation. ``` expect(MergeRequests::PushOptionsHandlerService).to receive(:new) ```
-
GitLab Bot authored
-
Stan Hu authored
Set correct timestamps when creating past issues Closes #58361 See merge request gitlab-org/gitlab-ce!27406
-
James Fargher authored
-
GitLab Bot authored
-
Annabel Dunstone Gray authored
`None` for assignees Closes #60599 See merge request gitlab-org/gitlab-ce!27419
-
Victor Wu authored
Update assignees_spec.js Update sidebar_spec.rb Update issues_spec.rb
-
GitLab Bot authored
-
Douglas Barbosa Alexandre authored
Test using Git 2.21 See merge request gitlab-org/gitlab-ce!27418
-
GitLab Bot authored
-
Michael Kozono authored
Resolve "Karma failing with MrWidgetAlertMessage when helpPath is provided Maximum call stack size exceeded" Closes #60605 See merge request gitlab-org/gitlab-ce!27429
-
Achilleas Pipinellis authored
Update the Operations Dashboard docs See merge request gitlab-org/gitlab-ee!11027
-
Achilleas Pipinellis authored
- Change image - Change product tier - Update the profile preferences docs
-
GitLab Bot authored
-
Nathan Friend authored
-
Achilleas Pipinellis authored
Docs: CI/CD intro - add new illustration + description See merge request gitlab-org/gitlab-ce!27278
-
Marcia Ramos authored
-
Achilleas Pipinellis authored
Link to resource label events API See merge request gitlab-org/gitlab-ce!27412
-
Victor Wu authored
-
GitLab Bot authored
-
Robert Speicher authored
Remove project_creation_level license check See merge request gitlab-org/gitlab-ee!11069
-
Imre Farkas authored
This was removed in dec08f02 but reintrodced in 980b8292 due to an incorrectly resolved merge conflict.
-
Marcia Ramos authored
Create frontend FAQ (documentation) See merge request gitlab-org/gitlab-ce!26372
-
Winnie Hellmann authored
-
GitLab Bot authored
-
Tim Zallmann authored
Replaced "View file" button with doc-text icon Closes #59034 See merge request gitlab-org/gitlab-ce!27365
-
Robert Speicher authored
Return Vulnerabilities::Feedback created_at column See merge request gitlab-org/gitlab-ee!11015
-
rossfuhrman authored
This will be used by the frontend to indicate how long ago an action was taken
-
GitLab Bot authored
-