- 05 Feb, 2019 40 commits
-
-
Nick Thomas authored
[API] Approval rule endpoints See merge request gitlab-org/gitlab-ee!8769
-
Nick Thomas authored
[EE] Reduce diff with CE in Groups::UpdateService See merge request gitlab-org/gitlab-ee!9426
-
Nick Thomas authored
[EE] Reduce the diff with CE in Ci::CreatePipelineService See merge request gitlab-org/gitlab-ee!9378
-
GitLab Bot authored
-
Achilleas Pipinellis authored
Docs: add index for project operations Closes #56115 See merge request gitlab-org/gitlab-ce!24565
-
Marcia Ramos authored
-
Achilleas Pipinellis authored
Docs: add index for project operations Closes gitlab-ce#56115 See merge request gitlab-org/gitlab-ee!9253
-
Marcia Ramos authored
-
Douglas Barbosa Alexandre authored
Reduce diff with EE in Search::GlobalService See merge request gitlab-org/gitlab-ce!24914
-
Douglas Barbosa Alexandre authored
[EE] Reduce diff with CE in Search::GlobalService See merge request gitlab-org/gitlab-ee!9427
-
Grzegorz Bizon authored
Resolve "Allow SSO enforcement in group settings for GitLab.com" Closes #5291 See merge request gitlab-org/gitlab-ee!9240
-
Paul Slaughter authored
-
Paul Slaughter authored
-
Paul Slaughter authored
Neded for client side validation and needed to know if a MR rule should be editable or not.
-
Paul Slaughter authored
-
Mark Chao authored
Use existing project PUT to update
-
Mark Chao authored
fallback_approvals_required should be checked in conjunction with code owner rules (if any)
-
Mark Chao authored
Specs are based from existing approvable spec.
-
Mark Chao authored
-
Mark Chao authored
Update spec
-
Mark Chao authored
-
Mark Chao authored
-
Mark Chao authored
-
Mark Chao authored
-
Mark Chao authored
-
Mark Chao authored
No longer need to consider overall_approvals_required
-
Mark Chao authored
-
Mark Chao authored
Fix spec so fallback path is tested
-
Mark Chao authored
-
Mark Chao authored
-
Mark Chao authored
It is helpful to not duplicate these paths in the FE.
-
Mark Chao authored
For the `approvals_settings` response. It was needed because we automatically populate the MR `rules` from the project if necessary, but there was no way for the edit UI to know if these were project rules or MR rules.
-
Mark Chao authored
-
Mark Chao authored
Now endpoints are under approval_settings scope.
-
Mark Chao authored
This excludes code owner rule
-
Mark Chao authored
Now endpoints are under approval_settings scope. Add PUT /projects/:id/approval_settings for updating overall approvals_required.
-
Mark Chao authored
Combine checking query
-
Mark Chao authored
Allow assigning project rule for MR rule When no MR approval rule, we don't validate as project rule will be used.
-
Mark Chao authored
This is to recompute the new overall_approvers In this method, the following calls would cause a change in the database which needs resetting the cache: - super (which updates MR) - sync_approval_rules (which updates rule record's approvals_required) - cleanup_approvers (which removes any approver not mentioned in params) resetting cache must be done after those three calls, so moving some calls earlier is required. However this would not affect outcome.
-
Mark Chao authored
Accepts nested attribute for rules
-