Enable Lint/BlockAlignment Rubocop cop

See #17478

See merge request !4346

Enable Style/RedundantParentheses rubocop cop

Checks for parentheses that seem not to serve any purpose.

See #17478 

See merge request !4361

Enable Style/SpaceBeforeComment rubocop cop

See #17478 

See merge request !4358

Enable Style/SpaceAfterMethodName rubocop cop

Do not put a space between a method name and the opening parenthesis  in a method definition.

See #17478

See merge request !4359

See #17478

See #17478

See #17478

Add DB index on users.state

See merge request !4336

See #17478

Closes #17920

Improve note validation

This MR improves note validation. Originates from #15577.

Closes #17260

See merge request !4024

❤

Use absolute paths in .gitignore

See merge request !4335

It's working fine now but by making it more explicit we can make tools
like 'The Silver Searcher' to parse properly the .gitignore file

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/15577

Use $ as the snippet prefix so it's consistent

## What does this MR do?

Change like `Snippet #20073` to `Snippet $20073`

## Are there points in the code the reviewer needs to double check?

Are there any other places need this change?

See merge request !4338

Project#show on projects pending deletion will 404

fixes #17508

See merge request !4156

fixes #17508

Fix import URL migration error

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/17956

See merge request !4321

Update notes immediately after closing/reopening

## What does this MR do?
Fixes MR https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4127 Thanks @bendyorke!
## Are there points in the code the reviewer needs to double check?
Nope.
## Why was this MR needed?
Constant conflicts in that MR
## What are the relevant issue numbers?

## Screenshots (if relevant)

Fixes #15091 

See merge request !4323

Fixed issue with calendar activity button not sending request correctly

When you click on a square it now sends the AJAX to the correct URL rather than the current URL. This was causing an issue where it would be loading the same page & inserting that into the DOM, rather than calendar activity events.

See merge request !4322