An error occurred fetching the project authors.
- 29 Nov, 2018 1 commit
-
-
Cindy Pallares authored
[master ee] Fixed ability to comment on and edit/delete comments on locked or confidential issues See merge request gitlab/gitlab-ee!739
-
- 12 Nov, 2018 1 commit
-
-
Yorick Peterse authored
This moves all instances of `prepend EE::Something` and `include EE::Something` in models to the last line of the corresponding model. This pushes EE specific code further down the files, reducing the likelihood of developers running into merge conflicts.
-
- 05 Nov, 2018 2 commits
-
-
Felipe Artur authored
-
Constance Okoghenun authored
This port resolves conflicts with CE version
-
- 31 Oct, 2018 1 commit
-
-
Sean McGivern authored
-
- 29 Oct, 2018 1 commit
-
-
Jan Provaznik authored
It's possible that user pastes accidentally also unsubscribe link which is included in footer of notification emails. This unsubscribe link contains personal token which attacker then use to act as the original user (e.g. for sending comments under his/her identity).
-
- 23 Oct, 2018 3 commits
-
-
Jan Provaznik authored
It's possible that user pastes accidentally also unsubscribe link which is included in footer of notification emails. This unsubscribe link contains personal token which attacker then use to act as the original user (e.g. for sending comments under his/her identity).
-
Oswaldo Ferreira authored
-
Felipe Artur authored
-
- 06 Oct, 2018 2 commits
- 02 Oct, 2018 2 commits
-
-
Brett Walker authored
-
Brett Walker authored
-
- 17 Sep, 2018 2 commits
-
-
Yorick Peterse authored
This commit adds the module `FromUnion`, which provides the class method `from_union`. This simplifies the process of selecting data from the result of a UNION, and reduces the likelihood of making mistakes. As a result, instead of this: union = Gitlab::SQL::Union.new([foo, bar]) Foo.from("(#{union.to_sql}) #{Foo.table_name}") We can now write this instead: Foo.from_union([foo, bar]) This commit also includes some changes to make this new setup work properly. For example, a bug in Rails 4 (https://github.com/rails/rails/issues/24193) would break the use of `from("sub-query-here").includes(:relation)` in certain cases. There was also a CI query which appeared to repeat a lot of conditions from an outer query on an inner query, which isn't necessary. Finally, we include a RuboCop cop to ensure developers use this new module, instead of using Gitlab::SQL::Union directly. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307
-
Yorick Peterse authored
This commit adds the module `FromUnion`, which provides the class method `from_union`. This simplifies the process of selecting data from the result of a UNION, and reduces the likelihood of making mistakes. As a result, instead of this: union = Gitlab::SQL::Union.new([foo, bar]) Foo.from("(#{union.to_sql}) #{Foo.table_name}") We can now write this instead: Foo.from_union([foo, bar]) This commit also includes some changes to make this new setup work properly. For example, a bug in Rails 4 (https://github.com/rails/rails/issues/24193) would break the use of `from("sub-query-here").includes(:relation)` in certain cases. There was also a CI query which appeared to repeat a lot of conditions from an outer query on an inner query, which isn't necessary. Finally, we include a RuboCop cop to ensure developers use this new module, instead of using Gitlab::SQL::Union directly. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307
-
- 13 Sep, 2018 1 commit
-
-
Robert Speicher authored
-
- 11 Sep, 2018 2 commits
-
-
Yorick Peterse authored
This whitelists all existing offenses for the various CodeReuse cops, of which most are triggered by the CodeReuse/ActiveRecord cop.
-
Yorick Peterse authored
This whitelists all existing offenses for the various CodeReuse cops, of which most are triggered by the CodeReuse/ActiveRecord cop.
-
- 07 Sep, 2018 2 commits
-
-
Jan Provaznik authored
-
Jan Provaznik authored
-
- 02 Aug, 2018 2 commits
-
-
Jarka Kadlecová authored
This reverts commit 13a267b9.
-
Jarka Kadlecová authored
This reverts commit 8717c7da.
-
- 01 Aug, 2018 1 commit
-
-
gfyoung authored
Partially addresses #47424.
-
- 30 Jul, 2018 1 commit
-
-
Bob Van Landuyt authored
The status is shown for - The author of a commit when viewing a commit - Notes on a commit (regular/diff) - The user that triggered a pipeline when viewing a pipeline - The author of a merge request when viewing a merge request - The author of notes on a merge request (regular/diff) - The author of an issue when viewing an issue - The author of notes on an issue - The author of a snippet when viewing a snippet - The author of notes on a snippet - A user's profile page - The list of members of a group/user
-
- 26 Jul, 2018 1 commit
-
-
gfyoung authored
Partially addresses #47424.
-
- 11 Jul, 2018 2 commits
-
-
Jarka Kadlecová authored
This reverts commit 79d64720, reversing changes made to 41c3e005. # Conflicts: # app/models/group.rb # ee/app/services/ee/todo_service.rb # ee/spec/features/epics/todo_spec.rb
-
Jarka Kadlecová authored
This reverts commit 4d9a3f42, reversing changes made to ecf9c145.
-
- 03 Jul, 2018 4 commits
-
-
Jarka Kadlecová authored
-
Jarka Kadlecová authored
-
Jan Provaznik authored
* Group filtering now includes also issues/MRs from subgroups/subprojects * fixed due_date * Also DRYed todo controller specs
-
Jan Provaznik authored
* Group filtering now includes also issues/MRs from subgroups/subprojects * fixed due_date * Also DRYed todo controller specs
-
- 21 Jun, 2018 2 commits
-
-
Felipe Artur authored
-
Winnie Hellmann authored
-
- 20 Jun, 2018 2 commits
-
-
Sean McGivern authored
-
Satish Perala authored
-
- 05 Jun, 2018 2 commits
-
-
Sean McGivern authored
This is tricky: the query was being run in `ObjectStorage::Extension::RecordsUploads#retrieve_from_store!`, but we can't just add batch loading there, because the `#upload=` method there would use the result immediately, making the batch only have one item. Instead, we can pre-emptively add an item to the batch whenever an avatarable object is initialized, and then reuse that batch item in `#retrieve_from_store!`. However, this also has problems: 1. There is a lot of logic in `Avatarable#retrieve_upload_from_batch`. 2. Some of that logic constructs a 'fake' model for the batch key. This should be fine, because of ActiveRecord's override of `#==`, but it relies on that staying the same.
-
Sean McGivern authored
This is tricky: the query was being run in `ObjectStorage::Extension::RecordsUploads#retrieve_from_store!`, but we can't just add batch loading there, because the `#upload=` method there would use the result immediately, making the batch only have one item. Instead, we can pre-emptively add an item to the batch whenever an avatarable object is initialized, and then reuse that batch item in `#retrieve_from_store!`. However, this also has problems: 1. There is a lot of logic in `Avatarable#retrieve_upload_from_batch`. 2. Some of that logic constructs a 'fake' model for the batch key. This should be fine, because of ActiveRecord's override of `#==`, but it relies on that staying the same.
-
- 24 May, 2018 2 commits
-
-
Oswaldo Ferreira authored
We request Gitaly in a N+1 manner to build discussion diffs. Once the diffs are from different revisions, it's hard to make a single request to the service in order to build the whole response. With this change we solve this problem and simplify a lot fetching this piece of info.
-
Oswaldo Ferreira authored
We request Gitaly in a N+1 manner to build discussion diffs. Once the diffs are from different revisions, it's hard to make a single request to the service in order to build the whole response. With this change we solve this problem and simplify a lot fetching this piece of info.
-
- 07 May, 2018 1 commit
-
-
Mario de la Ossa authored
-