- 02 Oct, 2020 39 commits
-
-
Dylan Griffith authored
This implements the same thing we implemented for [issues]( https://gitlab.com/gitlab-org/gitlab/-/merge_requests/40669 ) and [merge requests]( https://gitlab.com/gitlab-org/gitlab/-/merge_requests/42560 ) now for Epics. This required a slightly different approach as the `EpicsFinder` was not suitable for this purpose. At present it only supports searching within a single group. And extending it to support wider use cases would likely lead to performance issues as there is no equivalent group permissions cache like `project_authorizations` table to efficiently determine which groups a user can view epics in. The simpler thing to do here was to just manually check the permissions for each returned epic. This leaves a very edge case scenarion in which a user was previously able to see an epic and looked at that epic in their last 100 viewed epics and then performs a search and now only sees 4 suggestions (instead of the expected 5). This in theory, if the epic was renamed and the new name contained something important the user shouldn't see, could lead to the leak of an existence of that name in the search results. Considering this edge case is so unlikely it seems safe to not worry too much about it.
-
Dylan Griffith authored
We add 2 refactors: 1. Add `attr_reader :user` to RecentItems because this will be used by `RecentEpics` since the `EpicsFinder` cannot search outside of a single group like the `IssuesFinder` does so we need to override `#search` instead 2. Apply the limit=5 in the RecentItems module instead of the SearchHelper caller. This is necessary for when we implement Epics search because we'll need to do a permissions check on the limited items before returning them
-
Dylan Griffith authored
This is a necessary step to support recent epics as epics don't belong to a project but rather a group.
-
Evan Read authored
Update vale in docs-lint to 2.4.0 image See merge request gitlab-org/gitlab!44108
-
Shinya Maeda authored
Enable store_ci_pipeline_counts_by_status FF Closes #254721 See merge request gitlab-org/gitlab!43857
-
Jan Provaznik authored
Expose file path from XML Test Report artifact See merge request gitlab-org/gitlab!43594
-
Sean McGivern authored
Extend exception about chunk data not fulfilled in a bucket See merge request gitlab-org/gitlab!44007
-
Phil Hughes authored
Add group and issue for multiline comments FF See merge request gitlab-org/gitlab!44086
-
Heinrich Lee Yu authored
Add API Fuzzing plan limits db column See merge request gitlab-org/gitlab!43934
-
Michael Eddington authored
-
Marcel Amirault authored
Includes a docs change to test image
-
drew cimino authored
-
Sanad Liaquat authored
Add :requires_admin tag to skip ff test in production Closes #260283 See merge request gitlab-org/gitlab!44103
-
Simon Knox authored
Put issue notes behind startupjs See merge request gitlab-org/gitlab!43444
-
Donald Cook authored
-
Kushal Pandya authored
Convert Jest tests to use VTU in 'spec/frontend/issuable' See merge request gitlab-org/gitlab!43502
-
Evan Read authored
Clean up yaml code block formatting in monitor/configure/ecosystem docs See merge request gitlab-org/gitlab!43511
-
Kushal Pandya authored
Merge branch '223692-show-the-final-service-desk-custom-address-in-service-desk-settings-2' into 'master' Updated service desk settings See merge request gitlab-org/gitlab!43440
-
Sanad Liaquat authored
Group SAML SSO Specs: Use a new user for the tests instead of root Closes #254376 See merge request gitlab-org/gitlab!43832
-
Marcel Amirault authored
Fix spacing, indentation, comments, etc
-
Shinya Maeda authored
Remove Gitlab::Database.postgresql_9_or_less? method See merge request gitlab-org/gitlab!43564
-
Sean McGivern authored
We support version 11 as a minimum, so we don't need this any more.
-
Evan Read authored
Remove ancient geo redirects See merge request gitlab-org/gitlab!44101
-
Marcel Amirault authored
Doc: Remove use of "incredibly" in docs See merge request gitlab-org/gitlab!44066
-
Anastasia McDonald authored
See https://gitlab.com/gitlab-org/gitlab/-/issues/260283 for details
-
Marcel Amirault authored
As part of docs site improvements, we can now delete these
-
Evan Read authored
Removing notes from environments doc See merge request gitlab-org/gitlab!43632
-
charlie ablett authored
Revert "Merge branch 'ntepluhina-graphql-startup-js-2' into 'master'" See merge request gitlab-org/gitlab!44095
-
Miguel Rincon authored
Improve design for vulnerability details See merge request gitlab-org/gitlab!43274
-
Jacques Erasmus authored
Initial SSE merge request title/description meta See merge request gitlab-org/gitlab!43909
-
Ezekiel Kigbo authored
Remove bootstrap usage from merge_requests/invalid Closes #233674 See merge request gitlab-org/gitlab!43439
-
Alexander Turinske authored
- app/views/projects/merge_requests/invalid.html.haml - update text color
-
Dylan Griffith authored
Parse new scan object See merge request gitlab-org/gitlab!43736
-
Ezekiel Kigbo authored
Replace fa-warning with GitLab SVG icon in VSA limit warning See merge request gitlab-org/gitlab!43994
-
Martin Wortschack authored
-
Thong Kuah authored
This reverts merge request !36324
-
charlie ablett authored
Log `used_fields` information on GraphQL API See merge request gitlab-org/gitlab!42820
-
charlie ablett authored
Fix Jira DVCS user avatar path See merge request gitlab-org/gitlab!43563
-
Andy Soiron authored
Add missing spec for the GitHub API user entity.
-
- 01 Oct, 2020 1 commit
-
-
Ezekiel Kigbo authored
Apply GitLab UI button styles to buttons in app/views/projects/pages directory See merge request gitlab-org/gitlab!42776
-