- 06 Aug, 2021 2 commits
-
-
Dylan Griffith authored
This is because it is quite expensive to be reading this feature flag every single request. Checking an env var is much more efficient because feature flags are read from the database. This feature flag was not user- or administrator-facing. Changelog: other
-
Dylan Griffith authored
Ran rubocop -a after removing the disable.
-
- 05 Aug, 2021 26 commits
-
-
Dylan Griffith authored
This MR adds multiple new DB metrics to our logging when the `multiple_database_counters` feature flag is enabled. ```diff + "db_primary_primary_cached_count": 0, + "db_primary_primary_count": 0, + "db_primary_primary_duration_s": 0, + "db_replica_primary_cached_count": 0, + "db_replica_primary_count": 0, + "db_replica_primary_duration_s": 0, + "db_primary_primary_wal_count": 0, + "db_primary_primary_wal_cached_count": 0, + "db_replica_primary_wal_cached_count": 0, + "db_replica_primary_wal_count": 0, + "db_replica_primary_duration_s": 0, + "db_primary_primary_duration_s": 0, ``` These new fields indicate how many queries went to the database named `primary`. `primary` happens to be the default name Rails gives to the database connections described in `config/database.yml`. This is unfortunate as it conflicts with the `primary/replica` language we use to distinguish between read/write and read-only servers (hence `primary_primary` in the key) but this will change when we start explicitly setting the 2 databases we configure to be called `main` and `ci`. The feature flag exists to alleviate some of this confusion as described in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/66515 as only the ~group::sharding will need to use this for testing in the meantime. Prior to this change we already supported logging the `duration_s` data per database but we did not log the count of queries. When implementing this count of queries it became obvious it was much easier to implement these metrics in the same way that all the other metrics were implemented. In particular that they are logged as `0` even if there was no matching query. This led to quite a lot of refactoring because the list of `database_config_names` is dynamic. It's what is configured in `config/database.yml` and we had a tonne of tests that needed the full list of keys and values being logged.
-
Paul Slaughter authored
Merge branch '336388-convert-usage-of-timeago-mixin-to-time-ago-tooltip-in-package-registry' into 'master' Use time-ago-tooltip in package details title See merge request gitlab-org/gitlab!67494
-
Kushal Pandya authored
Geo Node Form Regression - Relative URLs broken See merge request gitlab-org/gitlab!67253
-
Paul Slaughter authored
Reset window location before every test [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!67353
-
Ash McKenzie authored
Curling Gitpod hostname requires cookies set See merge request gitlab-org/gitlab!67476
-
Ash McKenzie authored
-
David Kim authored
Use http(s) for the agent CI tunnel address See merge request gitlab-org/gitlab!67386
-
David Kim authored
Add support for security policy project for Projects::CreateService See merge request gitlab-org/gitlab!66448
-
Shinya Maeda authored
Allow downloading archives using PRIVATE-TOKEN [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!67470
-
Mark Lapierre authored
E2E: Update github import spec with proper validation See merge request gitlab-org/gitlab!67410
-
Shinya Maeda authored
Fix release group usage ping metrics definitions See merge request gitlab-org/gitlab!67224
-
Vladimir Shushlin authored
-
Evan Read authored
Remove now-incorrect doc line about SSH keys See merge request gitlab-org/gitlab!67530
-
Dan Jensen authored
-
Sashi authored
This change adds a new paramter for security policy target project in Projects::CreateService to create Security::OrchestrationPolicyConfiguration associated with the project. Changelog: added EE: true
-
charlie ablett authored
Display which GitLab branch we're on in Gitpod See merge request gitlab-org/gitlab!67558
-
Ash McKenzie authored
-
James Fargher authored
Remove duplicate AdditionalPack validation See merge request gitlab-org/gitlab!67514
-
Heinrich Lee Yu authored
Refine Documentation pages URL UI and documentation See merge request gitlab-org/gitlab!67293
-
Jaime Martinez authored
Related to https://gitlab.com/gitlab-org/gitlab/-/issues/28978 and https://gitlab.com/gitlab-org/gitlab/-/issues/334944. Changelog: changed
-
James Fargher authored
checks: Speed up retrieving commits via quarantine directory See merge request gitlab-org/gitlab!67210
-
Russell Dickenson authored
Add note about support for OpenApi v3.1 in API Fuzzing See merge request gitlab-org/gitlab!66544
-
Evan Read authored
Remove extra space from group token docs See merge request gitlab-org/gitlab!67543
-
Evan Read authored
Added to Docs Recommendation for access token expiration See merge request gitlab-org/gitlab!67040
-
Orit Golowinski authored
-
- 04 Aug, 2021 12 commits
-
-
Evan Read authored
Changelog: other EE: true
-
Suzanne Selhorn authored
Added guidance for this, these, that, those See merge request gitlab-org/gitlab!67545
-
Suzanne Selhorn authored
-
Marcel Amirault authored
Removed duplicate links See merge request gitlab-org/gitlab!67539
-
Russell Dickenson authored
Dependency Scanning: Simplify Poetry workaround See merge request gitlab-org/gitlab!67480
-
Mike Greiling authored
Update dependency yarn-deduplicate to v3 See merge request gitlab-org/gitlab!67522
-
Steve Abrams authored
Fix Stickiness to Match Unleash API See merge request gitlab-org/gitlab!66676
-
Serena Fang authored
-
GitLab Renovate Bot authored
-
Dan Davison authored
E2E: Add retry capability for paginated request and correctly handle errors See merge request gitlab-org/gitlab!67305
-
Andrejs Cunskis authored
-
Mike Greiling authored
Update dependency commander to ^2.20.3 See merge request gitlab-org/gitlab!67518
-