An error occurred fetching the project authors.
- 24 Nov, 2017 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 23 Nov, 2017 1 commit
-
-
Lin Jen-Shin authored
-
- 17 Nov, 2017 1 commit
-
-
Sean McGivern authored
Conflicts used to take a `Repository` and pass that to `Gitlab::Highlight.highlight`, which would call `#gitattribute` on the repository. Now they use a `Gitlab::Git::Repository`, which didn't have that method defined - but defining it on `Gitlab::Git::Repository` does make it available on `Repository` through `method_missing`, so we can do that and both cases will work.
-
- 16 Nov, 2017 3 commits
-
-
Jacopo authored
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
-
Rémy Coutable authored
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses. Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Yorick Peterse authored
This adds an optimised way of getting the latest pipeline status for a list of Commit objects (or just a single one).
-
- 10 Nov, 2017 1 commit
-
-
Jacob Vosmaer (GitLab) authored
-
- 08 Nov, 2017 2 commits
-
-
Yorick Peterse authored
Prior to this MR there were two GitHub related importers: * Github::Import: the main importer used for GitHub projects * Gitlab::GithubImport: importer that's somewhat confusingly used for importing Gitea projects (apparently they have a compatible API) This MR renames the Gitea importer to Gitlab::LegacyGithubImport and introduces a new GitHub importer in the Gitlab::GithubImport namespace. This new GitHub importer uses Sidekiq for importing multiple resources in parallel, though it also has the ability to import data sequentially should this be necessary. The new code is spread across the following directories: * lib/gitlab/github_import: this directory contains most of the importer code such as the classes used for importing resources. * app/workers/gitlab/github_import: this directory contains the Sidekiq workers, most of which simply use the code from the directory above. * app/workers/concerns/gitlab/github_import: this directory provides a few modules that are included in every GitHub importer worker. == Stages The import work is divided into separate stages, with each stage importing a specific set of data. Stages will schedule the work that needs to be performed, followed by scheduling a job for the "AdvanceStageWorker" worker. This worker will periodically check if all work is completed and schedule the next stage if this is the case. If work is not yet completed this worker will reschedule itself. Using this approach we don't have to block threads by calling `sleep()`, as doing so for large projects could block the thread from doing any work for many hours. == Retrying Work Workers will reschedule themselves whenever necessary. For example, hitting the GitHub API's rate limit will result in jobs rescheduling themselves. These jobs are not processed until the rate limit has been reset. == User Lookups Part of the importing process involves looking up user details in the GitHub API so we can map them to GitLab users. The old importer used an in-memory cache, but this obviously doesn't work when the work is spread across different threads. The new importer uses a Redis cache and makes sure we only perform API/database calls if absolutely necessary. Frequently used keys are refreshed, and lookup misses are also cached; removing the need for performing API/database calls if we know we don't have the data we're looking for. == Performance & Models The new importer in various places uses raw INSERT statements (as generated by `Gitlab::Database.bulk_insert`) instead of using Rails models. This allows us to bypass any validations and callbacks, drastically reducing the number of SQL queries and Gitaly RPC calls necessary to import projects. To ensure the code produces valid data the corresponding tests check if the produced rows are valid according to the model validation rules.
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 07 Nov, 2017 1 commit
-
-
Yorick Peterse authored
Prior to this MR there were two GitHub related importers: * Github::Import: the main importer used for GitHub projects * Gitlab::GithubImport: importer that's somewhat confusingly used for importing Gitea projects (apparently they have a compatible API) This MR renames the Gitea importer to Gitlab::LegacyGithubImport and introduces a new GitHub importer in the Gitlab::GithubImport namespace. This new GitHub importer uses Sidekiq for importing multiple resources in parallel, though it also has the ability to import data sequentially should this be necessary. The new code is spread across the following directories: * lib/gitlab/github_import: this directory contains most of the importer code such as the classes used for importing resources. * app/workers/gitlab/github_import: this directory contains the Sidekiq workers, most of which simply use the code from the directory above. * app/workers/concerns/gitlab/github_import: this directory provides a few modules that are included in every GitHub importer worker. == Stages The import work is divided into separate stages, with each stage importing a specific set of data. Stages will schedule the work that needs to be performed, followed by scheduling a job for the "AdvanceStageWorker" worker. This worker will periodically check if all work is completed and schedule the next stage if this is the case. If work is not yet completed this worker will reschedule itself. Using this approach we don't have to block threads by calling `sleep()`, as doing so for large projects could block the thread from doing any work for many hours. == Retrying Work Workers will reschedule themselves whenever necessary. For example, hitting the GitHub API's rate limit will result in jobs rescheduling themselves. These jobs are not processed until the rate limit has been reset. == User Lookups Part of the importing process involves looking up user details in the GitHub API so we can map them to GitLab users. The old importer used an in-memory cache, but this obviously doesn't work when the work is spread across different threads. The new importer uses a Redis cache and makes sure we only perform API/database calls if absolutely necessary. Frequently used keys are refreshed, and lookup misses are also cached; removing the need for performing API/database calls if we know we don't have the data we're looking for. == Performance & Models The new importer in various places uses raw INSERT statements (as generated by `Gitlab::Database.bulk_insert`) instead of using Rails models. This allows us to bypass any validations and callbacks, drastically reducing the number of SQL queries and Gitaly RPC calls necessary to import projects. To ensure the code produces valid data the corresponding tests check if the produced rows are valid according to the model validation rules.
-
- 06 Nov, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 03 Nov, 2017 7 commits
-
-
Alejandro Rodríguez authored
-
Alejandro Rodríguez authored
-
Alejandro Rodríguez authored
-
Alejandro Rodríguez authored
-
Alejandro Rodríguez authored
-
Alejandro Rodríguez authored
-
micael.bergeron authored
also, I refactored the MergeRequest#fetch_ref method to express the side-effect that this method has. MergeRequest#fetch_ref -> MergeRequest#fetch_ref! Repository#fetch_source_branch -> Repository#fetch_source_branch!
-
- 30 Oct, 2017 1 commit
-
-
Lin Jen-Shin authored
-
- 27 Oct, 2017 2 commits
-
-
Lin Jen-Shin (godfat) authored
-
Zeger-Jan van de Weg authored
Now, when requesting a commit from the Repository model, the results are not cached. This means we're fetching the same commit by oid multiple times during the same request. To prevent us from doing this, we now cache results. Caching is done only based on object id (aka SHA). Given we cache on the Repository model, results are scoped to the associated project, eventhough the change of two repositories having the same oids for different commits is small.
-
- 25 Oct, 2017 1 commit
-
-
Lin Jen-Shin authored
Fetch the merged branches at once, instead of checking it one by one in the view. We don't cache this yet because this would already much improve the performance. EE for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14729
-
- 24 Oct, 2017 1 commit
-
-
Alejandro Rodríguez authored
We also delete some unused code related to the aforementioned feature.
-
- 20 Oct, 2017 1 commit
-
-
Alejandro Rodríguez authored
This saves us Rugged/gRPC invocations
-
- 16 Oct, 2017 1 commit
-
-
Andrew Newdigate authored
-
- 13 Oct, 2017 5 commits
-
-
Alejandro Rodríguez authored
This prepares the codebase for a Gitaly migration. See https://gitlab.com/gitlab-org/gitaly/issues/553
-
Alejandro Rodríguez authored
-
Andrew Newdigate authored
-
Alejandro Rodríguez authored
This prepares the codebase for a Gitaly migration. See https://gitlab.com/gitlab-org/gitaly/issues/553
-
Alejandro Rodríguez authored
-
- 12 Oct, 2017 2 commits
-
-
Brett Walker authored
threshhold, a message is shown indicating we didn't perform the search
-
Sean McGivern authored
We were looking these up on each request to an issue page, because the form is pre-filled, as is the template dropdown. That was unnecessary: we could just treat these as 'special' repository files (like the rendered README) and cache them in Redis until they change on a push.
-
- 11 Oct, 2017 1 commit
-
-
Brett Walker authored
the long running git query
-
- 07 Oct, 2017 1 commit
-
-
Nick Thomas authored
-
- 04 Oct, 2017 1 commit
-
-
Jacob Vosmaer authored
-
- 02 Oct, 2017 1 commit
-
-
Stan Hu authored
`Repository#has_visible_content?` used to rely on the cached count of local branches, but since it is now an independently cached value it needs to be invalidated on its own. Closes #38646
-
- 29 Sep, 2017 1 commit
-
-
Jacob Vosmaer (GitLab) authored
-
- 26 Sep, 2017 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 25 Sep, 2017 1 commit
-
-
Andrew Newdigate authored
Allow n+1s caused by avatar fetches on the project dashboard. See https://gitlab.com/gitlab-org/gitlab-ce/issues/38261
-