1. 06 Mar, 2021 7 commits
    • Thomas Randolph's avatar
      Update the collapse state when the file changes, too · f710d4e0
      Thomas Randolph authored
      When the file loads, it's collapsed automatically
      if the user has reviewed it already.
      
      Unfortunately, this only happens when the component
      mounts.
      
      To make the component reactive - specifically in
      file-by-file mode - we add the check for the collapse
      state into a watcher on the file ID.
      
      Critically, we leave the `mounted` check in place, too.
      The first time the component is mounted, it has the
      initial file already present - the watcher won't trigger
      on that first render.
      f710d4e0
    • Thomas Randolph's avatar
      Use actual file IDs to retrieve reviews · 9b9a3814
      Thomas Randolph authored
      It's not very robust to retrieve a value by its position in an array.
      
      Instead, because the files all have unique IDs we return an
      object where each key is a file ID and it's value is whether that
      file has been marked as reviewed.
      
      This fixes the issue where the list of files in single-file mode
      always has a length of 1, which means the fetched review is
      always the first file in the MR.
      9b9a3814
    • Thomas Randolph's avatar
      Use the Vuex store as the primary source of reviews · 9222b48d
      Thomas Randolph authored
      Previously, the localStorage storage was the authoritative source.
      Now, the Vuex store is the authoritative source, with the localStorage
      store being the "backup"/persistent store.
      
      That means we need to push the localStorage values into the app,
      but reserve the `mrReviews` property for the mapped state.
      We do this by renaming the initial hydrator to "rehydratedMrReviews".
      9222b48d
    • Paul Slaughter's avatar
      Merge branch '229507-graphql-mutation-to-remove-issue-from-board' into 'master' · eadc6f28
      Paul Slaughter authored
      Remove Remove from board button from board sidebar [RUN ALL RSPEC] [RUN AS-IF-FOSS]
      
      See merge request gitlab-org/gitlab!53946
      eadc6f28
    • Simon Knox's avatar
      Remove remove from board button · 05a8a521
      Simon Knox authored
      This isn't implemented in graphql yet, and is a bit
      broken in regular boards.
      05a8a521
    • Amy Qualls's avatar
      Merge branch 'master' into 'master' · e9ccfaff
      Amy Qualls authored
      Update discussions.md to reflect reality
      
      See merge request gitlab-org/gitlab!51032
      e9ccfaff
    • Thomas DuBuisson's avatar
      ad51e782
  2. 05 Mar, 2021 33 commits