Skip to content

G
gitlab-ce
Switch branch/tag
  1. 05 Jun, 2018 1 commit
    • Lin Jen-Shin's avatar
      Also verify if extending would override a class method · f71fc932
      Lin Jen-Shin authored 
      Since extending a class means including on the singleton class of the
class, this should now complain this:

``` ruby
module M
  extend Gitlab::Utils::Override

  override :f
  def f
    super.succ
  end
end

class C
  extend M

  def self.f
    0
  end
end
```

It should complain because `C.f` wasn't calling `M#f`.
This should pass verification:

``` ruby
module M
  extend Gitlab::Utils::Override

  override :f
  def f
    super.succ
  end
end

class B
  def self.f
    0
  end
end

class C < B
  extend M
end
```

Because `C.f` would now call `M#f`, and `M#f` does override something.
      f71fc932
  3. 04 Jun, 2018 20 commits
  5. 03 Jun, 2018 3 commits
  7. 02 Jun, 2018 7 commits
  9. 01 Jun, 2018 9 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7