- 08 Jan, 2021 1 commit
-
-
Mark Florian authored
This updates to `@gitlab/eslint-plugin@6`, which includes breaking changes via the transitive dependency `eslint-plugin-vue` being upgraded from v6 to v7. This adds/improves various lint rules of Vue files; the full changes are documented in their [release post][1]. The most notable addition is the `vue/no-mutating-props` rule, which can help to prevent subtle runtime bugs. For several of the new/changed rules, the GitLab codebase has a number of violations. Rather than fixing all of them in this change, those new rules are disabled (e.g., `vue/no-mutating-props`), and the changed rules are reconfigured to mimic v6 settings (e.g., `vue/order-in-components`). This way, these can be addressed/fixed separately in follow ups. Otherwise, one-off violations, (e.g., of `vue/require-render-return`) have been fixed here. There were a few odd findings during this process that might suggest upstream bugs: 1. The `vue/one-component-per-file` rule finds what seems to be only false positives in this codebase, e.g., `~/registry/explorer/components/list_page/cli_commands.vue`; it _seems_ like the `Tracking.mixin` call is being considered as another component definition(?). 2. Three rules were violated by the line `spec/frontend/clusters/components/applications_spec.js:547`: `@gitlab/vue-require-required-key`, `vue/require-default-prop` and `vue/require-prop-type-constructor.` This is odd, because no Vue component was being defined or constructed there. Changing a `props` field to `propsData` resolved all three. Addresses https://gitlab.com/gitlab-org/gitlab/-/issues/296868, part of https://gitlab.com/groups/gitlab-org/-/epics/5142. [1]: https://github.com/vuejs/eslint-plugin-vue/releases/tag/v7.0.0
-
- 07 Jan, 2021 39 commits
-
-
GitLab Bot authored
-
🤖 GitLab Bot 🤖 authored
Update Gitaly version See merge request gitlab-org/gitlab!51138
-
Sean McGivern authored
Add RateLimit-* headers to RackAttack responses See merge request gitlab-org/gitlab!50833
-
Mike Jang authored
Update the Danger status docs after recent changes See merge request gitlab-org/gitlab!51120
-
Nick Gaskill authored
Documentation: Correct CI Job Token feature concept See merge request gitlab-org/gitlab!50920
-
Shinya Maeda authored
This commit corrects the wrong documentation.
-
Achilleas Pipinellis authored
Update reference architecture docs to use Patroni See merge request gitlab-org/gitlab!50573
-
Nailia Iskhakova authored
Starting from 13.7 PG12 is the default version for new installs and upgrades Repmgr is deprecated Signed-off-by:
Nailia Iskhakova <niskhakova@gitlab.com>
-
Suzanne Selhorn authored
Fix error: Could not find a matching version of package See merge request gitlab-org/gitlab!50614
-
baotang2118 authored
Expectation: after created a project under a user and invited groups, we can install composer package with with group ID. Bug: we are not able to install composer package with with group ID. Resolution: created a project under groups.
-
Igor Drozdov authored
Add ee metrics yml file for usage data metrics definition See merge request gitlab-org/gitlab!50990
-
Mike Jang authored
Merge branch '270107-add-metrics-yml-file-for-usage-data-metrics-definition-add-documentation' into 'master' Add documentation for metrics definition See merge request gitlab-org/gitlab!50770
-
Alina Mihaila authored
-
Enrique Alcántara authored
Follow-up for "POC: Search general settings" See merge request gitlab-org/gitlab!51111
-
Kerri Miller authored
Speed up EE project helpers by using let_it_be for project factory See merge request gitlab-org/gitlab!48891
-
GitLab Release Tools Bot authored
-
🤖 GitLab Bot 🤖 authored
Update Gitaly version See merge request gitlab-org/gitlab!51128
-
Mike Jang authored
Docs: clean up some Vale substitution warnings See merge request gitlab-org/gitlab!51049
-
Paul Slaughter authored
Fix branch name overflows in profile activity section See merge request gitlab-org/gitlab!50975
-
Nick Gaskill authored
Add link to GitLab HAR recorder See merge request gitlab-org/gitlab!50996
-
Sam Kerr authored
-
Nick Gaskill authored
Document UI methods of running an active DAST scan See merge request gitlab-org/gitlab!50816
-
Russell Dickenson authored
-
Heinrich Lee Yu authored
Validate GraphQL queries [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!50655
-
GitLab Release Tools Bot authored
-
Mark Florian authored
Populate On-demand Scan profiles using query params See merge request gitlab-org/gitlab!50749
-
Dheeraj Joshi authored
-
Mike Jang authored
Update gitlab.com availability in Compliance documentation See merge request gitlab-org/gitlab!51010
-
-
Mayra Cabrera authored
-
Amy Qualls authored
Docs: fix typo in csv_export.md See merge request gitlab-org/gitlab!51033
-
Robert Speicher authored
Spread CI minutes reset from 8 to 24 hours See merge request gitlab-org/gitlab!51084
-
Robert Speicher authored
Persist `squash_commit_sha` when squashing See merge request gitlab-org/gitlab!50178
-
Markus Koller authored
Fix 2.7 warning for sidekiq_middleware_spec.rb See merge request gitlab-org/gitlab!51093
-
Dan Davison authored
Add Jekyll GitLab Pages E2E smoke spec See merge request gitlab-org/gitlab!44653
-
Sarah Groff Hennigh-Palermo authored
Add Sentry to graph_component_wrapper See merge request gitlab-org/gitlab!50787
-
Jose Ivan Vargas authored
-
Paul Slaughter authored
For `search_settings_in_page`
-
Paul Slaughter authored
- We can simply wait for the method (no need for wait_for_promises) - `mockReset` isn't needed due to jest config
-