- 08 Nov, 2017 26 commits
-
-
Yorick Peterse authored
This task was broken in a few areas with the removal of the old GitHub importer code.
-
Yorick Peterse authored
This was removed by accident as the old GitHub importer handled this deep down the codebase, making it easy to miss.
-
Rémy Coutable authored
Fix Error 500 when pushing LFS objects with a write deploy key Closes #39467 See merge request gitlab-org/gitlab-ce!15039
-
Stan Hu authored
-
Nick Thomas authored
Added file storage documentation and updated hash storage one See merge request gitlab-org/gitlab-ce!15269
-
Rémy Coutable authored
Use Commit#notes and Note.for_commit_id when possible to make sure we use all indexes available to us Closes #34509 See merge request gitlab-org/gitlab-ce!15253
-
Gabriel Mazetto authored
-
Achilleas Pipinellis authored
Make a note of which files to check in after externalizing strings See merge request gitlab-org/gitlab-ce!15207
-
Phil Hughes authored
Resolve "Merge request widget - CI information has different margins" Closes #38395 See merge request gitlab-org/gitlab-ce!15237
-
Filipa Lacerda authored
-
Grzegorz Bizon authored
Fix test selection in Test::Integration::Mattermost See merge request gitlab-org/gitlab-ce!15278
-
Richard Clamp authored
In ce3b81b9 we changed Test::Integration::Mattermost#perform to consume a required positional parameter and pass on the rest of the arguments to the superclass. There was an error in implementation here and instead of splatting the files array to produce no additional arguments, we passed in the default case an empty array. This had the effect of calling rspec with no test files, rather than expected default of 'qa/specs/features` Here we correct that bug, and re-add the :core suite, as that was a poor deuction in the investagtion for 74d6b8a2.
-
Douwe Maan authored
Rewrite the GitHub importer to perform work in parallel and greatly improve performance Closes #33135, #38621, and #39361 See merge request gitlab-org/gitlab-ce!14731
-
Tim Zallmann authored
Added missing strings to prepare the tags page for internationalization See merge request gitlab-org/gitlab-ce!15256
-
Douwe Maan authored
Use Commit#notes and Note.for_commit_id when possible to make sure we use all the indexes available to us
-
Rémy Coutable authored
Add Internal QA specs to the pipeline See merge request gitlab-org/gitlab-ce!15240
-
Grzegorz Bizon authored
-
Bob Van Landuyt authored
-
Douwe Maan authored
Change Sign Out route from a DELETE to a GET Closes #39708 See merge request gitlab-org/gitlab-ce!15231
-
Tim Zallmann authored
Cleanup tests See merge request gitlab-org/gitlab-ce!15261
-
Douwe Maan authored
When deleting merged branches, ignore protected tags Closes #39732 See merge request gitlab-org/gitlab-ce!15252
-
Douwe Maan authored
Free some reserved group routes See merge request gitlab-org/gitlab-ce!15052
-
Stan Hu authored
Make BackgroundTransaction#labels public See merge request gitlab-org/gitlab-ce!15257
-
Mike Greiling authored
fix karma config file See merge request gitlab-org/gitlab-ce!15263
-
Marcia Ramos authored
Modals in UX guide See merge request gitlab-org/gitlab-ce!14886
-
Stan Hu authored
Adds typescript support in webpack. With Mike G. See merge request gitlab-org/gitlab-ce!15264
-
- 07 Nov, 2017 14 commits
-
-
Jacob Schatz authored
-
Jacob Schatz authored
-
Jacob Schatz authored
-
Yorick Peterse authored
-
Yorick Peterse authored
Prior to this MR there were two GitHub related importers: * Github::Import: the main importer used for GitHub projects * Gitlab::GithubImport: importer that's somewhat confusingly used for importing Gitea projects (apparently they have a compatible API) This MR renames the Gitea importer to Gitlab::LegacyGithubImport and introduces a new GitHub importer in the Gitlab::GithubImport namespace. This new GitHub importer uses Sidekiq for importing multiple resources in parallel, though it also has the ability to import data sequentially should this be necessary. The new code is spread across the following directories: * lib/gitlab/github_import: this directory contains most of the importer code such as the classes used for importing resources. * app/workers/gitlab/github_import: this directory contains the Sidekiq workers, most of which simply use the code from the directory above. * app/workers/concerns/gitlab/github_import: this directory provides a few modules that are included in every GitHub importer worker. == Stages The import work is divided into separate stages, with each stage importing a specific set of data. Stages will schedule the work that needs to be performed, followed by scheduling a job for the "AdvanceStageWorker" worker. This worker will periodically check if all work is completed and schedule the next stage if this is the case. If work is not yet completed this worker will reschedule itself. Using this approach we don't have to block threads by calling `sleep()`, as doing so for large projects could block the thread from doing any work for many hours. == Retrying Work Workers will reschedule themselves whenever necessary. For example, hitting the GitHub API's rate limit will result in jobs rescheduling themselves. These jobs are not processed until the rate limit has been reset. == User Lookups Part of the importing process involves looking up user details in the GitHub API so we can map them to GitLab users. The old importer used an in-memory cache, but this obviously doesn't work when the work is spread across different threads. The new importer uses a Redis cache and makes sure we only perform API/database calls if absolutely necessary. Frequently used keys are refreshed, and lookup misses are also cached; removing the need for performing API/database calls if we know we don't have the data we're looking for. == Performance & Models The new importer in various places uses raw INSERT statements (as generated by `Gitlab::Database.bulk_insert`) instead of using Rails models. This allows us to bypass any validations and callbacks, drastically reducing the number of SQL queries and Gitaly RPC calls necessary to import projects. To ensure the code produces valid data the corresponding tests check if the produced rows are valid according to the model validation rules.
-
Marcia Ramos authored
Add note on registry restrictions on GitLab.com See merge request gitlab-org/gitlab-ce!15174
-
Chenjerai Katanda authored
-
Annabel Dunstone Gray authored
Project with many branches can lock server running "git branch --contains XXX" Closes #37824 See merge request gitlab-org/gitlab-ce!14812
-
Jose Ivan Vargas authored
-
Yorick Peterse authored
The GitHub importer (and probably other parts of our code) ends up calling Feature.persisted? many times (via Gitaly). By storing this data in RequestStore we can save ourselves _a lot_ of database queries. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/39361
-
Yorick Peterse authored
This adds the keyword argument "return_ids" to Gitlab::Database.bulk_insert. When set to `true` (and PostgreSQL is used) this method will return an Array of the IDs of the inserted rows, otherwise it will return an empty Array.
-
Yorick Peterse authored
By using SQL::Union we can return a proper ActiveRecord::Relation, making it possible to select the columns we're interested in (instead of all of them).
-
Annabel Dunstone Gray authored
-
Filipa Lacerda authored
-