Commit 304bc473 authored by Tomasz Maczukin's avatar Tomasz Maczukin

Replace Summary with Histogram

parent 69184863
...@@ -34,14 +34,10 @@ var ( ...@@ -34,14 +34,10 @@ var (
Help: "How many requests are now queued", Help: "How many requests are now queued",
}) })
queueingWaitingTime = prometheus.NewSummary(prometheus.SummaryOpts{ queueingWaitingTime = prometheus.NewHistogram(prometheus.HistogramOpts{
Name: "gitlab_workhorse_queueing_waiting_time", Name: "gitlab_workhorse_queueing_waiting_time",
Help: "How many time a request spent in queue (0.5 and 0.95 percentile)", Help: "How many time a request spent in queue",
Objectives: map[float64]float64{ Buckets: []float64{0.01, 0.02, 0.05, 0.10, 0.20, 0.50, 1.00, 2.00, 5.00, 10.00, 30.00, 60.00},
0.50: 0.05,
0.95: 0.005,
0.99: 0.001,
},
}) })
queueingErrors = prometheus.NewCounterVec( queueingErrors = prometheus.NewCounterVec(
...@@ -100,7 +96,7 @@ func (s *Queue) Acquire(timeout time.Duration) (err error) { ...@@ -100,7 +96,7 @@ func (s *Queue) Acquire(timeout time.Duration) (err error) {
if err != nil { if err != nil {
waitStarted := <-s.waitingCh waitStarted := <-s.waitingCh
queueingWaiting.Dec() queueingWaiting.Dec()
queueingWaitingTime.Observe(float64(time.Since(waitStarted))) queueingWaitingTime.Observe(float64(time.Since(waitStarted).Seconds()))
} }
}() }()
...@@ -134,7 +130,7 @@ func (s *Queue) Release() { ...@@ -134,7 +130,7 @@ func (s *Queue) Release() {
// dequeue from queue to allow next request to be processed // dequeue from queue to allow next request to be processed
waitStarted := <-s.waitingCh waitStarted := <-s.waitingCh
queueingWaiting.Dec() queueingWaiting.Dec()
queueingWaitingTime.Observe(float64(time.Since(waitStarted))) queueingWaitingTime.Observe(float64(time.Since(waitStarted).Seconds()))
<-s.busyCh <-s.busyCh
queueingBusy.Dec() queueingBusy.Dec()
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment