1. 10 Apr, 2019 4 commits
    • Nick Thomas's avatar
      Merge branch 'release-8-5-1' into 'master' · be9f0805
      Nick Thomas authored
      Release v8.5.1
      
      See merge request gitlab-org/gitlab-workhorse!387
      be9f0805
    • Nick Thomas's avatar
      Release v8.5.1 · 14eb24d8
      Nick Thomas authored
      14eb24d8
    • Nick Thomas's avatar
      Merge branch 'sh-fix-performance-bar-ajax-requests' into 'master' · b513c936
      Nick Thomas authored
      Remove duplicate X-Request-Id response header
      
      Closes gitlab-ce#60111
      
      See merge request gitlab-org/gitlab-workhorse!384
      b513c936
    • Stan Hu's avatar
      Remove duplicate X-Request-Id response header · d44f2fb6
      Stan Hu authored
      This fixes performance bar not working with AJAX requests.
      
      Both LabKit and Rails were injecting duplicate X-Request-Id headers into
      the response stream, which caused the frontend to be interpret the value
      as a comma-separated value (e.g. LdEgVXsp1R4, LdEgVXsp1R4).
      
      The new flow behaves as the following:
      
      1. Workhorse injects X-Request-Id to the inbound HTTP request to Rails
      2. Rails looks up this value in its RequestId middleware. Since the
      value exists, Rails sets the X-Request-Id response header to this value.
      3. Workhorse doesn't append another header in the response.
      
      Distributed tracing should still work fine because Workhorse still
      generates the correlation ID.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60111
      d44f2fb6
  2. 04 Apr, 2019 4 commits
  3. 02 Apr, 2019 9 commits
  4. 01 Apr, 2019 2 commits
  5. 28 Mar, 2019 3 commits
  6. 25 Mar, 2019 4 commits
  7. 14 Mar, 2019 2 commits
  8. 27 Feb, 2019 3 commits
  9. 25 Feb, 2019 1 commit
  10. 18 Feb, 2019 2 commits
  11. 15 Feb, 2019 2 commits
  12. 13 Feb, 2019 2 commits
  13. 11 Feb, 2019 2 commits
    • Nick Thomas's avatar
      Merge branch 'send-correlation-id-in-response-headers' into 'master' · 054a2de5
      Nick Thomas authored
      Adds X-Request-Id response header for Workhorse
      
      See merge request gitlab-org/gitlab-workhorse!363
      054a2de5
    • Andrew Newdigate's avatar
      Adds X-Request-Id response header for Workhorse · ca4fd5ea
      Andrew Newdigate authored
      This change configures workhorse to set the Correlation-ID value in
      the response header. This is a common technique which allows errors to
      be traced more easily.
      
      This can be done through several methods: 1) users can review their
      browser headers and report the value 2) nginx error pages could be
      configured to report the correlation-id on the error page, allowing
      users to easily report it.
      
      Once the correlation-id has been reported, support engineers or
      production staff can use this to further investigate issues using
      logging infrastructure, sentry or distributed tracing.
      ca4fd5ea