query.js: do not raise if the sort_on_option list is empty

Fix the error

Error: TypeError: Cannot read property '0' of undefined

when synchronizing officejs apps (see https://nexedijs.erp5.net/#/bug_module/20190227-23F861F)

I confirm the synchro works again by applying this page locally.

I couldn't find where in the code (neither in jio and in ERP5) the sort_on parameter set to []. Maybe it's done dynamically somewhere (in replicate storage ?).

src/queries/query.js

       throw new TypeError("jioquery.sortOn(): " +
                           "Argument 1 is not of type 'array'");
     }
+    if (sort_on_option.length === 0) {
+      return list;
+    }
     list.sort(generateSortFunction(
       key_schema,
       sort_on_option

test/queries/tests.js

       });
   });*/
 
+  test('Empty sort_on options do not raise', function () {
+    var doc_list = [
+      {'a': 1},
+      {'c': 3},
+      {'b': 2}
+    ];
+
+    stop();
+    expect(1);
+    jIO.QueryFactory.create("").exec(
+      doc_list,
+      {
+        sort_on: [],
+      }
+    )
+      .then(function (list) {
+        deepEqual(list, [
+          {'a': 1},
+          {'c': 3},
+          {'b': 2}
+        ], 'Sorting didn\'t raise');
+      }).always(start);
+  });
+
   test('Multiple sort_on options', function () {
     var i,
       len = 1000,

[Nicolas Wavrant]

@romain : what do you think of this MR ?

[Romain Courteaud]

Please add a test to reproduce the issue to fix and ensure jslint passes.

[Nicolas Wavrant]

Hi @romain ,

I pushed a test. I checked that without the fix in query.js this test raises.

Commits are already squashed. You can merge if you feel it is OK