• Nicolai Stange's avatar
    um: asm/page.h: remove the pte_high member from struct pte_t · 012a4163
    Nicolai Stange authored
    Commit 16da3068 ("um: kill pfn_t") introduced a compile warning for
    defconfig (SUBARCH=i386):
    
      arch/um/kernel/skas/mmu.c:38:206:
          warning: right shift count >= width of type [-Wshift-count-overflow]
    
    Aforementioned patch changes the definition of the phys_to_pfn() macro
    from
    
      ((pfn_t) ((p) >> PAGE_SHIFT))
    
    to
    
      ((p) >> PAGE_SHIFT)
    
    This effectively changes the phys_to_pfn() expansion's type from
    unsigned long long to unsigned long.
    
    Through the callchain init_stub_pte() => mk_pte(), the expansion of
    phys_to_pfn() is (indirectly) fed into the 'phys' argument of the
    pte_set_val(pte, phys, prot) macro, eventually leading to
    
      (pte).pte_high = (phys) >> 32;
    
    This results in the warning from above.
    
    Since UML only deals with 32 bit addresses, the upper 32 bits from
    'phys' used to be always zero anyway.  Also, all page protection flags
    defined by UML don't use any bits beyond bit 9.  Since the contents of a
    PTE are defined within architecture scope only, the ->pte_high member
    can be safely removed.
    
    Remove the ->pte_high member from struct pte_t.
    Rename ->pte_low to ->pte.
    Adapt the pte helper macros in arch/um/include/asm/page.h.
    
    Noteworthy is the pte_copy() macro where a smp_wmb() gets dropped.  This
    write barrier doesn't seem to be paired with any read barrier though and
    thus, was useless anyway.
    
    Fixes: 16da3068 ("um: kill pfn_t")
    Signed-off-by: default avatarNicolai Stange <nicstange@gmail.com>
    Cc: Dan Williams <dan.j.williams@intel.com>
    Cc: Richard Weinberger <richard@nod.at>
    Cc: Nicolai Stange <nicstange@gmail.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    012a4163
page.h 3.15 KB