• Lothar Waßmann's avatar
    leds: trigger: gpio: fix warning in gpio trigger for gpios whose accessor function may sleep · 914ae25a
    Lothar Waßmann authored
    When using a GPIO driver whose accessor functions may sleep (e.g. an
    I2C GPIO extender like PCA9554) the following warning is issued:
    WARNING: CPU: 0 PID: 665 at drivers/gpio/gpiolib.c:2274 gpiod_get_raw_value+0x3c/0x48()
    Modules linked in:
    CPU: 0 PID: 665 Comm: kworker/0:2 Not tainted 3.16.0-karo+ #115
    Workqueue: events gpio_trig_work
    [<c00142cc>] (unwind_backtrace) from [<c00118f8>] (show_stack+0x10/0x14)
    [<c00118f8>] (show_stack) from [<c001bf10>] (warn_slowpath_common+0x64/0x84)
    [<c001bf10>] (warn_slowpath_common) from [<c001bf4c>] (warn_slowpath_null+0x1c/0x24)
    [<c001bf4c>] (warn_slowpath_null) from [<c020a1b8>] (gpiod_get_raw_value+0x3c/0x48)
    [<c020a1b8>] (gpiod_get_raw_value) from [<c02f68a0>] (gpio_trig_work+0x1c/0xb0)
    [<c02f68a0>] (gpio_trig_work) from [<c0030c1c>] (process_one_work+0x144/0x38c)
    [<c0030c1c>] (process_one_work) from [<c0030ef8>] (worker_thread+0x60/0x5cc)
    [<c0030ef8>] (worker_thread) from [<c0036dd4>] (kthread+0xb4/0xd0)
    [<c0036dd4>] (kthread) from [<c000f0f0>] (ret_from_fork+0x14/0x24)
    ---[ end trace cd51a1dad8b86c9c ]---
    
    Fix this by using the _cansleep() variant of gpio_get_value().
    Signed-off-by: default avatarLothar Waßmann <LW@KARO-electronics.de>
    Signed-off-by: default avatarBryan Wu <cooloney@gmail.com>
    914ae25a
ledtrig-gpio.c 6.13 KB