• Geert Uytterhoeven's avatar
    pinctrl: sh-pfc: Do not overwrite bias configuration · 05c5f265
    Geert Uytterhoeven authored
    After the last user of the in_pd/in_pu bias parameters of the _PCRH()
    macro was removed in commit 80da8e02 ("sh-pfc: r8a7740: Add bias
    (pull-up/down) pinconf support"), bias parameters are supposed to be
    configured using the generic pinctl mechanism, which calls the
    .set_bias() method.
    
    However, the PORTCR() macro still represents the control register as
    consisting of two 4-bit fields. Hence the bias configuration in the
    uppermost 2 bits is always overwritten with zeroes when a pin is
    configured for GPIO, disabling any previously configured bias.
    
    Use the variable config register macro instead, to represent the
    register as having 4 fields, and to make sure only the input/output
    control and function fields are touched.
    
    This affects R-Mobile APE6 (r8a73a4), R-Mobile A1 (r8a7740), SH-Mobile
    AP4 (sh7372), and SH-Mobile AG5 (sh73a0).
    Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
    Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    05c5f265
sh_pfc.h 9.6 KB