• Rodrigo Vivi's avatar
    drm/i915/cnl: Fix wrpll math for higher freqs. · 063c8861
    Rodrigo Vivi authored
    Spec describe all values in MHz. We handle our
    clocks in KHz. This includes the best_dco_centrality that was
    forgot in the same unity as spec. Consequently we couldn't
    get a good divider for high frequenies. Hence HDMI 2.0 wasn't
    working.
    
    Spec tells 999999 for initial best_dco_centrality meaning the
    max value in MHz.
    Since we convert dco from MHz to KHz we also need to convert
    this initial best_doc_centrality to 999999000 or 999999999
    or even better, to the max that its variable allow.
    
    This patch also replaces the use of "* KHz(1)" with the values
    directly on KHz to avoid future confusion.
    
    v2: Use U32_MAX instead of random 99999 as spec tells. (Ville).
    
    Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Cc: Shashank Sharma <shashank.sharma@intel.com>
    Cc: Mika Kahola <mika.kahola@intel.com>
    Cc: Manasi Navare <manasi.d.navare@intel.com>
    Cc: James Ausmus <james.ausmus@intel.com>
    Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
    Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20171114234223.10600-1-rodrigo.vivi@intel.com
    063c8861
intel_dpll_mgr.c 64.2 KB