• Chris Wilson's avatar
    drm/i915: Use uninterruptible mutex_lock for userptr bo creation · 281400ff
    Chris Wilson authored
    Mika encountered one pathological scenario under X where acquiring all
    the mm locks (required to insert a mmu notifier) was very slow, so slow
    that by the time we tried to lock the struct_mutex with the usual call
    to i915_mutex_lock_interruptible(), X's signal timer had fired causing
    us to restart the ioctl (and so looped indefinitely).
    
    While I suspect this is the result of another bug (something leaking mm
    perhaps?) we can forgo the error checking and interuptible nature of the
    lock here so we only have to pay the expense once and get on with it.
    This does expose the userptr creation routine to a driver livelock
    though by not being interruptible.
    Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    Cc: Mika Kuoppala <mika.kuoppala@intel.com>
    [danvet: Init ret to avoid issues reported by PRTS.]
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    281400ff
i915_gem_userptr.c 22.2 KB