• Marco Elver's avatar
    kcsan: Skew delay to be longer for certain access types · 106a307f
    Marco Elver authored
    For compound instrumentation and assert accesses, skew the watchpoint
    delay to be longer if randomized. This is useful to improve race
    detection for such accesses.
    
    For compound accesses we should increase the delay as we've aggregated
    both read and write instrumentation. By giving up 1 call into the
    runtime, we're less likely to set up a watchpoint and thus less likely
    to detect a race. We can balance this by increasing the watchpoint
    delay.
    
    For assert accesses, we know these are of increased interest, and we
    wish to increase our chances of detecting races for such checks.
    
    Note that, kcsan_udelay_{task,interrupt} define the upper bound delays.
    When randomized, delays are uniformly distributed between [0, delay].
    Skewing the delay does not break this promise as long as the defined
    upper bounds are still adhered to. The current skew results in delays
    uniformly distributed between [delay/2, delay].
    Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Signed-off-by: default avatarMarco Elver <elver@google.com>
    Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
    106a307f
core.c 35.2 KB