• Jean Delvare's avatar
    [PATCH] I2C: Kill i2c_algorithm.id (6/7) · 1684a984
    Jean Delvare authored
    In theory, there should be no more users of I2C_ALGO_* at this point.
    However, it happens that several drivers were using I2C_ALGO_* for
    adapter ids, so we need to correct these before we can get rid of all
    the I2C_ALGO_* definitions.
    
    Note that this also fixes a bug in media/video/tvaudio.c:
    
    	/* don't attach on saa7146 based cards,
    	   because dedicated drivers are used */
    	if ((adap->id & I2C_ALGO_SAA7146))
    		return 0;
    
    This test was plain broken, as it would succeed for many more adapters
    than just the saa7146: any those id would share at least one bit with
    the saa7146 id. We are really lucky that the few other adapters we want
    this driver to work with did not fulfill that condition.
    Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    1684a984
pluto2.c 19.2 KB