• Michael Ellerman's avatar
    powerpc/pci: Fix IO space breakage after of_pci_range_to_resource() change · aeba3731
    Michael Ellerman authored
    Commit 0b0b0893 "of/pci: Fix the conversion of IO ranges into IO
    resources" changed the behaviour of of_pci_range_to_resource().
    
    Previously it simply populated the resource based on the arguments. Now
    it calls pci_register_io_range() and pci_address_to_pio(). These both
    have two implementations depending on whether PCI_IOBASE is defined,
    which it is not for powerpc.
    
    Further complicating matters, both routines are weak, and powerpc
    implements it's own version of one - pci_address_to_pio(). However
    powerpc's implementation depends on other initialisations which are done
    later in boot.
    
    The end result is incorrectly initialised IO space. Often we can get
    away with that, because we don't make much use of IO space. However
    virtio requires it, so we see eg:
    
      pci_bus 0000:00: root bus resource [io  0xffff] (bus address [0xffffffffffffffff-0xffffffffffffffff])
      PCI: Cannot allocate resource region 0 of device 0000:00:01.0, will remap
      virtio-pci 0000:00:01.0: can't enable device: BAR 0 [io  size 0x0020] not assigned
    
    The simplest fix for now is to just stop using of_pci_range_to_resource(),
    and open-code the original implementation, that's all we want it to do.
    
    Fixes: 0b0b0893 ("of/pci: Fix the conversion of IO ranges into IO resources")
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    aeba3731
pci-common.c 46.3 KB