• Julia Lawall's avatar
    drivers/atm/idt77252.c: Remove unnecessary error check · 1790c228
    Julia Lawall authored
    This code does not call deinit_card(card); in an error case, as done in
    other error-handling code in the same function.  But actually, the called
    function init_sram can only return 0, so there is no need for the error
    check at all.
    
    init_sram is also given a void return type, and its single return statement
    at the end of the function is dropped.
    
    A simplified version of the sematic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @r exists@
    @r@
    statement S1,S2,S3;
    constant C1,C2,C3;
    @@
    
    *if (...)
     {... S1 return -C1;}
    ...
    *if (...)
     {... when != S1
        return -C2;}
    ...
    *if (...)
     {... S1 return -C3;}
    // </smpl>
    Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    1790c228
idt77252.c 90.5 KB