• David Howells's avatar
    rxrpc: Fix received abort handling · 17e9e23b
    David Howells authored
    AF_RXRPC is incorrectly sending back to the server any abort it receives
    for a client connection.  This is due to the final-ACK offload to the
    connection event processor patch.  The abort code is copied into the
    last-call information on the connection channel and then the event
    processor is set.
    
    Instead, the following should be done:
    
     (1) In the case of a final-ACK for a successful call, the ACK should be
         scheduled as before.
    
     (2) In the case of a locally generated ABORT, the ABORT details should be
         cached for sending in response to further packets related to that
         call and no further action scheduled at call disconnect time.
    
     (3) In the case of an ACK received from the peer, the call should be
         considered dead, no ABORT should be transmitted at this time.  In
         response to further non-ABORT packets from the peer relating to this
         call, an RX_USER_ABORT ABORT should be transmitted.
    
     (4) In the case of a call killed due to network error, an RX_USER_ABORT
         ABORT should be cached for transmission in response to further
         packets, but no ABORT should be sent at this time.
    
    Fixes: 3136ef49 ("rxrpc: Delay terminal ACK transmission on a client call")
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    17e9e23b
conn_client.c 33 KB