• Shuah Khan's avatar
    [media] drx-j: fix boot failure due to null pointer dereference · 1ad77b5c
    Shuah Khan authored
    DJH_DEBUG only code path in drxbsp_i2c_write_read() dereferences
    w_dev_addr and subsequently w_dev_addr->user_data->i2c which results
    in failure during boot. This patch fixes the null pointer derefence
    bug as well as the following compile errors:
    
      LD      arch/x86/built-in.o
      CC      drivers/media/dvb-frontends/drx39xyj/drxj.o
    drivers/media/dvb-frontends/drx39xyj/drxj.c: In function ‘drxbsp_i2c_write_read’:
    drivers/media/dvb-frontends/drx39xyj/drxj.c:1558:25: error: redeclaration of ‘state’ with no linkage
      struct drx39xxj_state *state = w_dev_addr->user_data;
                             ^
    drivers/media/dvb-frontends/drx39xyj/drxj.c:1512:25: note: previous declaration of ‘state’ was here
      struct drx39xxj_state *state;
                             ^
    drivers/media/dvb-frontends/drx39xyj/drxj.c:1558:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
      struct drx39xxj_state *state = w_dev_addr->user_data;
      ^
    drivers/media/dvb-frontends/drx39xyj/drxj.c:1560:17: error: redeclaration of ‘msg’ with no linkage
      struct i2c_msg msg[2] = {
                     ^
    drivers/media/dvb-frontends/drx39xyj/drxj.c:1513:17: note: previous declaration of ‘msg’ was here
      struct i2c_msg msg[2];
                     ^
    Signed-off-by: default avatarShuah Khan <shuah.kh@samsung.com>
    Acked-by: default avatarDevin Heitmueller <dheitmueller@kernellabs.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
    1ad77b5c
drxj.c 575 KB