• Ben Hutchings's avatar
    kconfig/nconf: Fix hang when editing symbol with a long prompt · 1af5e763
    Ben Hutchings authored
    commit 79e51b5c upstream.
    
    Currently it is impossible to edit the value of a config symbol with a
    prompt longer than (terminal width - 2) characters.  dialog_inputbox()
    calculates a negative x-offset for the input window and newwin() fails
    as this is invalid.  It also doesn't check for this failure, so it
    busy-loops calling wgetch(NULL) which immediately returns -1.
    
    The additions in the offset calculations also don't match the intended
    size of the window.
    
    Limit the window size and calculate the offset similarly to
    show_scroll_win().
    
    Fixes: 692d97c3 ("kconfig: new configuration interface (nconfig)")
    Signed-off-by: default avatarBen Hutchings <ben.hutchings@codethink.co.uk>
    [bwh: Backported to 3.2: replaced code used LINES and COLS]
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    1af5e763
nconf.gui.c 14.6 KB