• Masahiro Yamada's avatar
    kconfig: remove S_OTHER symbol type and correct dependency tracking · 2aabbed6
    Masahiro Yamada authored
    The S_OTHER type could be set only when conf_read_simple() is reading
    include/config/auto.conf file.
    
    For example, CONFIG_FOO=y exists in include/config/auto.conf but it is
    missing from the currently parsed Kconfig files, sym_lookup() allocates
    a new symbol, and sets its type to S_OTHER.
    
    Strangely, it will be set to S_STRING by conf_set_sym_val() a few lines
    below while it is obviously bool or tristate type. On the other hand,
    when CONFIG_BAR="bar" is being dropped from include/config/auto.conf,
    its type remains S_OTHER. Because for_all_symbols() omits S_OTHER
    symbols, conf_touch_deps() misses to touch include/config/bar.h
    
    This behavior has been a pretty mystery for me, and digging the git
    histroy did not help. At least, touching depfiles is broken for string
    type symbols.
    
    I removed S_OTHER entirely, and reimplemented it more simply.
    
    If CONFIG_FOO was visible in the previous syncconfig, but is missing
    now, what we want to do is quite simple; just call conf_touch_dep()
    to touch include/config/foo.h instead of allocating a new symbol data.
    Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
    2aabbed6
confdata.c 27.1 KB