• Zhao Lei's avatar
    btrfs: Cleanup for btrfs_calc_num_tolerated_disk_barrier_failures · 2c458045
    Zhao Lei authored
    1: Use ARRAY_SIZE(types) to replace a static-value variant:
       int num_types = 4;
    
    2: Use 'continue' on condition to reduce one level tab
       if (!XXX) {
           code;
           ...
       }
       ->
       if (XXX)
           continue;
       code;
       ...
    
    3: Put setting 'num_tolerated_disk_barrier_failures = 2' to
       (num_tolerated_disk_barrier_failures > 2) condition to make
       make logic neat.
       if (num_tolerated_disk_barrier_failures > 0 && XXX)
           num_tolerated_disk_barrier_failures = 0;
       else if (num_tolerated_disk_barrier_failures > 1) {
           if (XXX)
               num_tolerated_disk_barrier_failures = 1;
           else if (XXX)
               num_tolerated_disk_barrier_failures = 2;
       ->
       if (num_tolerated_disk_barrier_failures > 0 && XXX)
           num_tolerated_disk_barrier_failures = 0;
       if (num_tolerated_disk_barrier_failures > 1 && XXX)
           num_tolerated_disk_barrier_failures = ;
       if (num_tolerated_disk_barrier_failures > 2 && XXX)
           num_tolerated_disk_barrier_failures = 2;
    
    4: Remove comment of:
       num_mirrors - 1: if RAID1 or RAID10 is configured and more
       than 2 mirrors are used.
       which is not fit with code.
    Signed-off-by: default avatarZhao Lei <zhaolei@cn.fujitsu.com>
    Signed-off-by: default avatarChris Mason <clm@fb.com>
    2c458045
disk-io.c 120 KB