• Petr Machata's avatar
    net: sched: Fix hw_stats_type setting in pedit loop · 2c4b58dc
    Petr Machata authored
    In the commit referenced below, hw_stats_type of an entry is set for every
    entry that corresponds to a pedit action. However, the assignment is only
    done after the entry pointer is bumped, and therefore could overwrite
    memory outside of the entries array.
    
    The reason for this positioning may have been that the current entry's
    hw_stats_type is already set above, before the action-type dispatch.
    However, if there are no more actions, the assignment is wrong. And if
    there are, the next round of the for_each_action loop will make the
    assignment before the action-type dispatch anyway.
    
    Therefore fix this issue by simply reordering the two lines.
    
    Fixes: 74522e7b ("net: sched: set the hw_stats_type in pedit loop")
    Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    2c4b58dc
cls_api.c 92.6 KB