• Nathan Fontenot's avatar
    powerpc/pseries: Correct string length in pseries_of_derive_parent() · f755ecfb
    Nathan Fontenot authored
    Commit a030e1e4 make a change to use
    kstrndup() instead of kmalloc() + strlcpy() in the pseries_of_derive_parent()
    routine that introduces a subtle change in the parent path name generated.
    The kstrndup() routine will copy n characters followed by a terminating null,
    whereas strlcpy() will copy n-1 characters and add a terminating null.
    
    This slight difference results in having a parent path that includes the
    tailing '/' character, "/cpus/" vs. "/cpus". This then causes the subsequent
    call to of_find_node_by_path() to fail, and in the case of DLPAR add
    operations the DLPAR request fails.
    
    This patch decrements the pointer returned from kbasename() to point to the
    '/' character before the base name instead of the base name. This then
    adjusts the string length calculations to not include the trailing '/'
    in the parent path name.
    Signed-off-by: default avatarNathan Fontenot <nfont@linux.vnet.ibm.com>
    Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    f755ecfb
of_helpers.c 976 Bytes